From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>,
Antoine Tenart <atenart@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org,
Clayton Shotwell <clayton.shotwell@collins.com>,
Matt Weber <matthew.weber@collins.com>
Subject: Re: [Buildroot] [PATCH 4/4] package/android-tools: add host gcc >= 5 dependency
Date: Wed, 5 Jan 2022 22:02:08 +0100 [thread overview]
Message-ID: <20220105210208.GJ614810@scaer> (raw)
In-Reply-To: <20220105180402.388388-4-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2022-01-05 19:04 +0100, Fabrice Fontaine spake thusly:
> Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add host
> gcc >= 5 dependency
>
> Fixes:
> - No autobuilder failures (yet)
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/android-tools/Config.in.host | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/android-tools/Config.in.host b/package/android-tools/Config.in.host
> index 433f4e384f..576e53e8b5 100644
> --- a/package/android-tools/Config.in.host
> +++ b/package/android-tools/Config.in.host
> @@ -10,12 +10,16 @@ config BR2_PACKAGE_HOST_ANDROID_TOOLS
> if BR2_PACKAGE_HOST_ANDROID_TOOLS
>
> config BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT
> + depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
> bool "fastboot"
> help
> This option will build and install the fastboot utility for
> the host, which can be used to reflash target devices
> implementing the fastboot protocol.
>
> +comment "fastboot needs a toolchain w/ host gcc >= 5"
> + depends on !BR2_HOST_GCC_AT_LEAST_5
> +
> config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB
> bool "adb"
> help
> @@ -24,10 +28,14 @@ config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB
> implementing the ADB protocol.
>
> config BR2_PACKAGE_HOST_ANDROID_TOOLS_EXT4_UTILS
> + depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
$ make check-package
package/android-tools/Config.in.host:14: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
package/android-tools/Config.in.host:32: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
Applied to master after fixing this, thanks.
Regards,
Yann E. MORIN.
> bool "ext4 utils"
> help
> This option will build and install the ext4 utils for the
> host, i.e. make_ext4fs, ext4fixup, ext2simg, img2simg,
> simg2img and simg2simg.
>
> +comment "ext4 utils needs a toolchain w/ host gcc >= 5"
> + depends on !BR2_HOST_GCC_AT_LEAST_5
> +
> endif
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-05 21:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 18:03 [Buildroot] [PATCH 1/4] package/libsemanage: add gcc >= 5 dependency Fabrice Fontaine
2022-01-05 18:04 ` [Buildroot] [PATCH 2/4] package/refpolicy: add host " Fabrice Fontaine
2022-01-05 18:04 ` [Buildroot] [PATCH 3/4] package/checkpolicy: " Fabrice Fontaine
2022-01-05 18:04 ` [Buildroot] [PATCH 4/4] package/android-tools: " Fabrice Fontaine
2022-01-05 21:02 ` Yann E. MORIN [this message]
2022-01-05 21:00 ` [Buildroot] [PATCH 1/4] package/libsemanage: add " Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105210208.GJ614810@scaer \
--to=yann.morin.1998@free.fr \
--cc=atenart@kernel.org \
--cc=buildroot@buildroot.org \
--cc=clayton.shotwell@collins.com \
--cc=fontaine.fabrice@gmail.com \
--cc=marcus.folkesson@gmail.com \
--cc=matthew.weber@collins.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox