From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Romain Naour <romain.naour@smile.fr>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
marc.chalain@mailoo.org, Marc Chalain <marc.chalain@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] package/aravis: new package
Date: Thu, 6 Jan 2022 10:37:59 +0100 [thread overview]
Message-ID: <20220106103759.1166357c@windsurf> (raw)
In-Reply-To: <faf7a836-82a1-04b9-89de-d9a7825df776@smile.fr>
Hello,
On Thu, 6 Jan 2022 10:24:53 +0100
Romain Naour <romain.naour@smile.fr> wrote:
> > diff --git a/package/aravis/Config.in b/package/aravis/Config.in
> > new file mode 100644
> > index 0000000000..02c71c44da
> > --- /dev/null
> > +++ b/package/aravis/Config.in
> > @@ -0,0 +1,16 @@
> > +config BR2_PACKAGE_ARAVIS
> > + bool "aravis - GigE Camera"
Just:
bool "aravis"
> > + depends on BR2_USE_WCHAR
> > + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> > + depends on BR2_PACKAGE_PCRE_16
> > + depends on BR2_PACKAGE_PCRE_32
Please use "select" for pcre.
> > +ARAVIS_LICENSE_FILES = COPYING
> > +ARAVIS_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
>
> Is gettext a mandatory dependency ?
> At least gettext should be in ARAVIS_DEPENDENCIES when NLS support is enabled.
No, don't add gettext directly, use $(TARGET_NLS_DEPENDENCIES), which
will automatically add (or not) host-gettext and/or gettext to the
dependencies, depending on when it's needed or not.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-06 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 15:57 [Buildroot] package/aravis: new package marc.chalain
2022-01-06 9:24 ` Romain Naour
2022-01-06 9:37 ` Thomas Petazzoni [this message]
2022-01-07 20:08 ` marc.chalain
2022-01-08 10:31 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106103759.1166357c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=marc.chalain@gmail.com \
--cc=marc.chalain@mailoo.org \
--cc=romain.naour@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox