From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 3/7] package/rustc: fix BR2_PACKAGE_HOST_RUSTC_ARCH for ARMv5
Date: Fri, 7 Jan 2022 18:57:13 +0100 [thread overview]
Message-ID: <20220107185713.7b1d5224@windsurf> (raw)
In-Reply-To: <20220107171318.1423075-4-thomas.petazzoni@bootlin.com>
On Fri, 7 Jan 2022 18:13:13 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> BR2_PACKAGE_HOST_RUSTC_ARCH only had a special value for
> BR2_ARM_CPU_ARMV7A, but it also needs a special value for
> BR2_ARM_CPU_ARMV5, as the pre-compiled Rust standard library for
> ARMv5TE is identified with the "armv5te" architecture name, see
> https://doc.rust-lang.org/nightly/rustc/platform-support.html.
>
> We noticed this because Rust binaries wouldn't work on an ARMv5
> platform (Illegal instruction). This was due to the usage of the
> arm-unknown-linux-gnueabi variant of the Rust standard library, which
> is for ARMv6. Thanks to this commit, we correctly use the
> armv5te-unknown-linux-gnueabi variant, and Rust binaries work properly
> on ARMv5TE.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/rustc/Config.in.host | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
> index 90ea56f626..05324ad755 100644
> --- a/package/rustc/Config.in.host
> +++ b/package/rustc/Config.in.host
> @@ -102,6 +102,7 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
>
> config BR2_PACKAGE_HOST_RUSTC_ARCH
> string
> + default "armv5te" if BR2_ARM_CPU_ARMV5
> default "armv7" if BR2_ARM_CPU_ARMV7A
> default BR2_ARCH if !BR2_ARM_CPU_ARMV7A
I need to drop the "if !BR2_ARM_CPU_ARMV7A" here. Will do in the next
iteration, or can be done when applying if there are no other comments.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-07 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 17:13 [Buildroot] [PATCH 0/7] Bump of python-cryptography and other Rust related fun Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 1/7] package/ca-certificates: remove dependency on host-python-cryptography Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 2/7] package/python-cryptography: drop host variant Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 3/7] package/rustc: fix BR2_PACKAGE_HOST_RUSTC_ARCH for ARMv5 Thomas Petazzoni
2022-01-07 17:57 ` Thomas Petazzoni [this message]
2022-01-07 17:13 ` [Buildroot] [PATCH 4/7] package/rustc: fix the riscv64gc architecture handling Thomas Petazzoni
2022-01-08 0:23 ` Alistair Francis
2022-01-07 17:13 ` [Buildroot] [PATCH 5/7] support/download/cargo-post-process: make manifest path configurable Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 6/7] support/testing/tests: switch python-cryptography related tests to glibc Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 7/7] DO-NOT-APPLY package/python-cryptography: bump version to 36.0.1 Thomas Petazzoni
2022-01-08 16:52 ` [Buildroot] [PATCH 0/7] Bump of python-cryptography and other Rust related fun Arnout Vandecappelle
2022-01-09 11:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107185713.7b1d5224@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox