Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Olivier Schonken <olivier.schonken@gmail.com>,
	Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qpdf: needs atomic
Date: Fri, 7 Jan 2022 22:08:57 +0100	[thread overview]
Message-ID: <20220107220857.63b9a0da@windsurf> (raw)
In-Reply-To: <20220104210727.3634208-1-fontaine.fabrice@gmail.com>

On Tue,  4 Jan 2022 22:07:27 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> qpdf needs atomic since bump to version 10.5.0 in commit
> b5352c2177011ca389cbb7c68e78447549cbdaaa and
> https://github.com/qpdf/qpdf/commit/c5c1a028cdd3cf345046c46963fb0fdacfb2c33c:
> 
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: /home/buildroot/autobuild/instance-2/output-1/build/qpdf-10.5.0/libqpdf/build/.libs/libqpdf.a(QPDF.o): in function `QPDF::QPDF()':
> QPDF.cc:(.text+0x48de): undefined reference to `__atomic_fetch_add_8'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/7e18689670dcbe491c35f0597e5c3c787936263f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/cups-filters/Config.in | 2 ++
>  package/qpdf/Config.in         | 2 ++
>  2 files changed, 4 insertions(+)

Applied to master, thanks. However, could you do a test build on
sparcv8 ? Indeed normally when something needs atomic, it also needs to
link with libatomic when available, as some architectures (such as
sparcv8) have all atomic built-ins implemented in libatomic.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-07 21:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 21:07 [Buildroot] [PATCH 1/1] package/qpdf: needs atomic Fabrice Fontaine
2022-01-07 21:08 ` Thomas Petazzoni [this message]
2022-01-07 21:16   ` Fabrice Fontaine
2022-01-07 21:50     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220107220857.63b9a0da@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=angelo.compagnucci@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=olivier.schonken@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox