From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Joseph Kogut <joseph.kogut@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/alsa-lib: disable versioned symbols only when unsupported
Date: Sat, 8 Jan 2022 11:04:14 +0100 [thread overview]
Message-ID: <20220108110414.69f9fb65@windsurf> (raw)
In-Reply-To: <20200518051112.33798-1-joseph.kogut@gmail.com>
Hello Joseph,
On Sun, 17 May 2020 22:11:12 -0700
Joseph Kogut <joseph.kogut@gmail.com> wrote:
> Some libraries such as CEF depend on versioned symbols from alsa-lib,
> and the build fails during linking with versioning disabled.
>
> Symbol versioning was originally disabled because some C libraries, such
> as uClibc, don't support versioned symbols.
>
> This patch conditionally disables versioned symbols when unsupported by
> the toolchain, leaving them enabled otherwise.
>
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
> package/alsa-lib/alsa-lib.mk | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Sorry for the delay. I have applied with a much more detailed commit
log, and also after enabling versioned symbols only with glibc
toolchains, as musl only has partial support for symbol versioning.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-08 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 18:33 [Buildroot] [PATCH 1/1] package/alsa-lib: build with versioned symbols Joseph Kogut
2020-05-15 19:46 ` Thomas Petazzoni
2020-05-18 5:11 ` [Buildroot] [PATCH v2 1/1] package/alsa-lib: disable versioned symbols only when unsupported Joseph Kogut
2022-01-08 10:04 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220108110414.69f9fb65@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=joseph.kogut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox