Re: [Buildroot] [PATCH 3/7] package/rockchip-mali-bifrost: new package with binary blobs

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Peter Seiderer <ps.report@gmx.net>,
	Julien Corjon <corjon.j@ecagroup.com>,
	buildroot@buildroot.org, Luca Ceresoli <luca@lucaceresoli.net>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 3/7] package/rockchip-mali-bifrost: new package with binary blobs
Date: Sat, 8 Jan 2022 17:20:19 +0100	[thread overview]
Message-ID: <20220108172019.4cb27c8e@windsurf> (raw)
In-Reply-To: <20200306071440.30433-4-miquel.raynal@bootlin.com>

On Fri,  6 Mar 2020 08:14:36 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> From: Maxime Chevallier <maxime.chevallier@bootlin.com>
> 
> There is already a package adding Mali blobs for Sunxi Mali Utgard
> GPUs. Many Rockchip SoCs feature a Mali Bifrost GPU and need specific
> libraries provided under binary form with a non-GPL compliant license
> by Rockchip. Package these libraries.
> 
> Define a common *_INSTALL_CMDS macro, which takes as argument the base
> destination path, and use it to implement *_INSTALL_TARGET_CMDS and
> *_INSTALL_STAGING_CMDS.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  package/Config.in                             |   1 +
>  ...4-binaries-and-only-install-the-bifr.patch | 169 ++++++++++++++++++
>  package/rockchip-mali-bifrost/Config.in       |  20 +++
>  .../rockchip-mali-bifrost.hash                |   2 +
>  .../rockchip-mali-bifrost.mk                  |  85 +++++++++
>  5 files changed, 277 insertions(+)
>  create mode 100644 package/rockchip-mali-bifrost/0001-cmake-Use-AArch64-binaries-and-only-install-the-bifr.patch
>  create mode 100644 package/rockchip-mali-bifrost/Config.in
>  create mode 100644 package/rockchip-mali-bifrost/rockchip-mali-bifrost.hash
>  create mode 100644 package/rockchip-mali-bifrost/rockchip-mali-bifrost.mk

Thanks for this patch, which we have finally applied! I did a large
number of changes, almost rewriting it entirely:

    [Thomas:
    - Rename to rockchip-mali, because it contains other blobs than
      Bifrost ones
    - Add missing entry in DEVELOPERS file
    - Change BR2_arm to BR2_ARM_EABIHF as only EABIhf blobs are provided
      for arm32
    - Add BR2_TOOLCHAIN_HAS_THREADS inherited from libdrm.
    - Expose as a libgbm provider.
    - Drop the patch, which was not necessary.
    - Rework the entire installation logic, to be much simpler.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot