Re: [Buildroot] [PATCH v2 1/5] package/alchemy: new host package

[Herve Codina <herve.codina@bootlin.com>]

Hi Yann,

On Sat, 1 Jan 2022 16:50:22 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Hervé, All,
> 
> On 2021-11-12 14:12 +0100, Herve Codina spake thusly:
> > Alchemy is a build system developed by Parrot.
> > 
> > It is a new build system based on the one used in Android.
> > A central makefile instance scans a workspace to find user
> > makefiles, includes them and register modules to be built.
> > 
> > https://github.com/Parrot-Developers/alchemy
> > 
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>  
> 
> I was about to push this, with a few changes, but I have some questions
> about the packages, so here's the patch of the changes I did:
> 
>     [yann.morin.1998@free.fr:
>       - use ALCHEMY_HOME everywhere rather than repeating the location in
>         the install macro
>       - don't remove install dir before installing
>       - use a template for atom.mk, not in-line in alchemy.mk
>     ]
> 
>     diff --git a/package/alchemy/alchemy.mk b/package/alchemy/alchemy.mk
>     index 63d5a941c5..f802c62425 100644
>     --- a/package/alchemy/alchemy.mk
>     +++ b/package/alchemy/alchemy.mk
>     @@ -10,19 +10,19 @@ ALCHEMY_LICENSE = BSD-3-Clause (Alchemy), GPL-2.0 (kconfig)
>      ALCHEMY_LICENSE_FILES = COPYING README
>      HOST_ALCHEMY_DEPENDENCIES = host-python3
>      
>     +ALCHEMY_HOME = $(HOST_DIR)/opt/alchemy
>      ALCHEMY_SDK_BASEDIR = $(STAGING_DIR)/usr/lib/alchemy/sdk
>      
>      define HOST_ALCHEMY_INSTALL_CMDS
>     -	rm -rf $(HOST_DIR)/opt/alchemy
>     -	mkdir -p $(HOST_DIR)/opt/alchemy
>     -	cp -rf $(@D)/* $(HOST_DIR)/opt/alchemy/
>     +	mkdir -p $(ALCHEMY_HOME)
>     +	cp -rf $(@D)/* $(ALCHEMY_HOME)
>     +	cp $(ALCHEMY_PKGDIR)/atom.mk.in $(ALCHEMY_HOM	E)/atom.mk.in
>      endef
>      
>      $(eval $(host-generic-package))
>      
>      # Variables used by other packages
>      
>     -ALCHEMY_HOME = $(HOST_DIR)/opt/alchemy
>      ALCHEMY_MAKE = $(ALCHEMY_HOME)/scripts/alchemake
>      
>      # TARGET_ARCH is set to 'xxx' to avoid Alchemy managing the architecture.
>     @@ -59,14 +59,11 @@ endif
>      # $2: Alchemy module name
>      # $3: Alchemy module file name
>      define ALCHEMY_INSTALL_LIB_SDK_FILE
>     -	mkdir -p $(ALCHEMY_SDK_BASEDIR)/$(strip $(1))
>     -	( \
>     -		echo 'LOCAL_PATH := $$(call my-dir)'; \
>     -		echo 'include $$(CLEAR_VARS)'; \
>     -		echo 'LOCAL_MODULE := $(strip $(2))'; \
>     -		echo 'LOCAL_SDK := $(STAGING_DIR)'; \
>     -		echo 'LOCAL_DESTDIR := usr/lib'; \
>     -		echo 'LOCAL_MODULE_FILENAME := $(strip $(3))'; \
>     -		echo 'include $$(BUILD_LIBRARY)'; \
>     -	) > $(ALCHEMY_SDK_BASEDIR)/$(strip $(1))/atom.mk
>     +	$(INSTALL) -m 0644 -D \
>     +		$(ALCHEMY_HOME)/atom.mk.in \
>     +		$(ALCHEMY_SDK_BASEDIR)/$(strip $(1))/atom.mk
>     +	$(SED) 's#@STAGING_DIR@#$(STAGING_DIR)#' \
>     +		-e 's#@MODULE@#$(strip $(2))#' \
>     +		-e 's#@MODULE_FILENAME@#$(strip $(3))#' \
>     +		$(ALCHEMY_SDK_BASEDIR)/$(strip $(1))/atom.mk
>      endef
>     diff --git a/package/alchemy/atom.mk.in b/package/alchemy/atom.mk.in
>     new file mode 100644
>     index 0000000000..30eb6d5e23
>     --- /dev/null
>     +++ b/package/alchemy/atom.mk.in
>     @@ -0,0 +1,7 @@
>     +LOCAL_PATH := $(call my-dir)
>     +include $(CLEAR_VARS)
>     +LOCAL_MODULE := @MODULE@
>     +LOCAL_SDK := @STAGING_DIR@
>     +LOCAL_DESTDIR := usr/lib
>     +LOCAL_MODULE_FILENAME := @MODULE_FILENAME@
>     +include $(BUILD_LIBRARY)
> 

I take these modifications with a few changes.
They will be part of the v3 series.

Thanks,
Hervé


-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot