From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Romain Naour <romain.naour@gmail.com>,
Peter Seiderer <ps.report@gmx.net>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mesa3d: Gallium VC4 driver depends on NEON
Date: Sun, 9 Jan 2022 21:14:02 +0100 [thread overview]
Message-ID: <20220109201402.GE1477939@scaer> (raw)
In-Reply-To: <20220109171511.3293111-1-arnout@mind.be>
Arnout, All,
On 2022-01-09 18:15 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Since version 21.3.0 of mesa3d, the generic broadcom infrastructure
> (which is called v3d but is used also for VC4) started using NEON
> instructions. This leads to assembler failures when VC4 is built for
> 32-bit ARM without NEON:
>
> FAILED: src/broadcom/libv3d_neon.a.p/common_v3d_tiling.c.o
> /home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc [...] -c ../src/broadcom/common/v3d_tiling.c
> /tmp/ccAvufNv.s: Assembler messages:
> /tmp/ccAvufNv.s:602: Error: selected processor does not support `vldm r7,{q0,q1,q2,q3}' in ARM mode
> [...]
> /tmp/ccAvufNv.s:686: Error: selected processor does not support `vstm r7,{q0,q1,q2,q3}' in ARM mode
>
> Let the VC4 driver depend on NEON for 32-bit ARM. Aarch64 always has
> NEON, so no condition is needed there.
>
> Fixes:
> http://autobuild.buildroot.net/results/2b5/2b531f7aa4506ee31a7252c87a2e401fffab9dfb/
> http://autobuild.buildroot.net/results/6f9/6f9e7c864808dc0fafbca7c8984651fe92edbaf2/
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/mesa3d/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 34b0352056..37c4f8078e 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -274,7 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D
>
> config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4
> bool "Gallium vc4 driver"
> - depends on BR2_arm || BR2_aarch64
> + depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64
> depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # libxshmfence
> select BR2_PACKAGE_MESA3D_DRI3 if BR2_PACKAGE_XORG7
> select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-09 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 17:15 [Buildroot] [PATCH] package/mesa3d: Gallium VC4 driver depends on NEON Arnout Vandecappelle (Essensium/Mind)
2022-01-09 17:24 ` Romain Naour
2022-01-09 18:11 ` Arnout Vandecappelle
2022-01-09 20:14 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109201402.GE1477939@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=ps.report@gmx.net \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox