From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Paul Soucy <paul.soucy@sense.com>
Cc: Stephan Hoffmann <sho@relinux.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gtest: host-gtest install like a normal cmake package
Date: Sun, 9 Jan 2022 22:00:20 +0100 [thread overview]
Message-ID: <20220109210020.GI1477939@scaer> (raw)
In-Reply-To: <20201216174404.47363-1-paul.soucy@sense.com>
Paul, All,
Sorry for the long delay...
On 2020-12-16 12:44 -0500, Paul Soucy spake thusly:
> host-gtest does not actually build and install gtest libraries or header files, it just installs the gmock_gen stuff. This patch will now build and install gtest to the host like a normal cmake package.
I rewrapped the commit log, and slightly extended it with the
information you rpovided elsewhere in the thread.
> Signed-off-by: Paul Soucy <paul.soucy@sense.com>
> ---
> package/gtest/gtest.mk | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/package/gtest/gtest.mk b/package/gtest/gtest.mk
> index 7f967b8bfb..f35ae63383 100644
> --- a/package/gtest/gtest.mk
> +++ b/package/gtest/gtest.mk
> @@ -88,14 +88,15 @@ else
> GTEST_CONF_OPTS += -DBUILD_GMOCK=OFF
> endif
>
> -define HOST_GTEST_INSTALL_CMDS
> +define HOST_GTEST_POST_INSTALL_PYTHON
> $(INSTALL) -D -m 0755 $(@D)/googlemock/scripts/generator/gmock_gen.py \
> $(HOST_DIR)/bin/gmock_gen
> cp -rp $(@D)/googlemock/scripts/generator/cpp \
> $(HOST_GTEST_GMOCK_PYTHONPATH)
> endef
>
> +HOST_GTEST_POST_INSTALL_HOOKS += HOST_GTEST_POST_INSTALL_PYTHON
> +
> +
$ make check-package
package/gtest/gtest.mk:64: consecutive empty lines
Applied to master with the above fixed, thanks.
Regards,
Yann E. MORIN.
> $(eval $(cmake-package))
> -# The host package does not build anything, just installs gmock_gen stuff, so
> -# it does not need to be a host-cmake-package.
> -$(eval $(host-generic-package))
> +$(eval $(host-cmake-package))
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-09 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 17:44 [Buildroot] [PATCH 1/1] package/gtest: host-gtest install like a normal cmake package Paul Soucy
2020-12-30 14:43 ` Thomas Petazzoni
2020-12-30 15:13 ` Paul Soucy
2022-01-09 21:00 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109210020.GI1477939@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=paul.soucy@sense.com \
--cc=sho@relinux.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox