From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: yegorslists@googlemail.com
Cc: "Wojciech M . Zabolotny" <wzab01@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface
Date: Mon, 10 Jan 2022 15:04:50 +0100 [thread overview]
Message-ID: <20220110140450.GO1477939@scaer> (raw)
In-Reply-To: <20220110085850.11095-2-yegorslists@googlemail.com>
Yegor, All,
On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/avrdude/Config.in | 3 +++
> package/avrdude/avrdude.mk | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/package/avrdude/Config.in b/package/avrdude/Config.in
> index 89558a5ff5..57a8df66ea 100644
> --- a/package/avrdude/Config.in
> +++ b/package/avrdude/Config.in
> @@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
>
> if BR2_PACKAGE_AVRDUDE
>
> +config BR2_PACKAGE_AVRDUDE_LINUXGPIO
> + bool "Linux sysfs GPIO interface support"
> +
> config BR2_PACKAGE_AVRDUDE_SPI
> bool "SPI support"
> default y # Backward compatibility
> diff --git a/package/avrdude/avrdude.mk b/package/avrdude/avrdude.mk
> index accd92c1d5..3ccba80d8e 100644
> --- a/package/avrdude/avrdude.mk
> +++ b/package/avrdude/avrdude.mk
> @@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
> AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
> host-flex host-bison
>
> +ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
> +AVRDUDE_CONF_OPTS += --enable-linuxgpio
> +else
> +AVRDUDE_CONF_OPTS += --disable-linuxgpio
> +endif
We already have an unconditional activation of those:
https://github.com/buildroot/buildroot/blob/master/package/avrdude/avrdude.mk#L15
(which you can btw. incidentally also notice as part the hunk header).
So, if the intention was to be able to enable linux-gpio, then this is a
noop as they are already enabled. If the intention was to be able to
disable them, then the unconditional enable should be dropped.
But then, does it make sense to be able to disable linux GPIO?
And what if both SPI and GPIO are disabled?
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
> AVRDUDE_CONF_OPTS += --enable-linuxspi
> else
> --
> 2.17.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-10 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 8:58 [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov yegorslists--- via buildroot
2022-01-10 8:58 ` [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface yegorslists--- via buildroot
2022-01-10 14:04 ` Yann E. MORIN [this message]
2022-01-10 17:59 ` Yegor Yefremov via buildroot
2022-01-10 14:14 ` [Buildroot] [PATCH 1/2] DEVELOPERS: add entry for avrdude to Yegor Yefremov Yann E. MORIN
2022-01-27 18:30 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220110140450.GO1477939@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=wzab01@gmail.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox