Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: romain.naour@smile.fr, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/python-greenlet: enable as host package
Date: Mon, 10 Jan 2022 16:49:54 +0100	[thread overview]
Message-ID: <20220110154954.GR1477939@scaer> (raw)
In-Reply-To: <20220110141140.77224ac0@camb691.localdomain>

Cyril, All,

On 2022-01-10 14:11 +0000, Cyril Bur spake thusly:
> While currently there is no in-tree Buildroot package which depends on
> host-python-greenlet, we (Adder Technology) have some proprietary
> modules that use it as part of their builds.
> 
> I've tested python-greenlet as host package and confirmed that it builds
> and works correctly. Someone else might require it, so I'm proposing its
> inclusion.

In all theory, host-python-greenlet should have the same dependencies
toward the host that the target variant has toward the target:

    config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS
        bool
        default y if BR2_arm || BR2_armeb
        default y if BR2_aarch64
        default y if BR2_csky
        default y if BR2_m68k
        default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
        default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
        default y if BR2_riscv
        default y if BR2_sparc || BR2_sparc64
        default y if BR2_i386 || BR2_x86_64

However, in practice, hosts that are commonly used to run Buildroot are
virtually all in that list: x86 or x86_64, AArch64 (and maybe a very few
arms just for the fun), PPC, and maybe a few adventurous on riscv.

So in practice, we do not care.

> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> v2: Half completed commit message update - sorry
> v3: Updated commit message and Config.in.host
> 
>  package/Config.in.host                     | 1 +
>  package/python-greenlet/Config.in.host     | 7 +++++++
>  package/python-greenlet/python-greenlet.mk | 1 +
>  3 files changed, 9 insertions(+)
>  create mode 100644 package/python-greenlet/Config.in.host
> 
> diff --git a/package/Config.in.host b/package/Config.in.host
> index b3e00bb482..6e027d96c2 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -69,6 +69,7 @@ menu "Host utilities"
>  	source "package/pwgen/Config.in.host"
>  	source "package/python/Config.in.host"
>  	source "package/python-cython/Config.in.host"
> +	source "package/python-greenlet/Config.in.host"
>  	source "package/python-lxml/Config.in.host"
>  	source "package/python-six/Config.in.host"
>  	source "package/python-xlrd/Config.in.host"
> diff --git a/package/python-greenlet/Config.in.host b/package/python-greenlet/Config.in.host
> new file mode 100644
> index 0000000000..673fee8cc5
> --- /dev/null
> +++ b/package/python-greenlet/Config.in.host
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_HOST_PYTHON_GREENLET
> +	bool "host python-greenlet"
> +	help
> +	  Greenlets are lightweight coroutines for in-process concurrent
> +	  programming.
> +
> +	  https://greenlet.readthedocs.io/
> diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk
> index 7b983ff0ef..3b1ef7e314 100644
> --- a/package/python-greenlet/python-greenlet.mk
> +++ b/package/python-greenlet/python-greenlet.mk
> @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0
>  PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF
>  
>  $(eval $(python-package))
> +$(eval $(host-python-package))
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-01-10 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 14:52 [Buildroot] [PATCH] package/python-greenlet: enable as host package Cyril Bur
2022-01-08 18:43 ` Romain Naour
2022-01-08 19:03   ` Cyril Bur
2022-01-08 19:13     ` Romain Naour
2022-01-08 19:16       ` Cyril Bur
2022-01-10 13:02 ` [Buildroot] [PATCH v2] " Cyril Bur
2022-01-10 14:07   ` Cyril Bur
2022-01-10 14:11 ` [Buildroot] [PATCH v3] " Cyril Bur
2022-01-10 15:49   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110154954.GR1477939@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=cyrilbur@gmail.com \
    --cc=romain.naour@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox