Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Michael Fischer <mf@go-sys.de>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 1/1] package/rtl8723bu: bump version to d34603a39a7c925d810fe17c6e8dea5063d43a33
Date: Mon, 10 Jan 2022 16:58:23 +0100	[thread overview]
Message-ID: <20220110155823.GS1477939@scaer> (raw)
In-Reply-To: <20220110151302.21093-1-mf@go-sys.de>

Michael, All,

On 2022-01-10 16:13 +0100, Michael Fischer spake thusly:
> patch 0001: Disable concurrrent mode. This causes disconnections.

That patch is missing a commit log and a sign-off for itself:

    # ./utils/check-package package/rtl8723bu/0001-disable_concurent_mode.patch
    package/rtl8723bu/0001-disable_concurent_mode.patch:0: missing Signed-off-by in the header
    (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)

But see below...

> Signed-off-by: Michael Fischer <mf@go-sys.de>
> ---
>  package/rtl8723bu/0001-disable_concurent_mode.patch | 12 ++++++++++++
>  package/rtl8723bu/rtl8723bu.hash                    |  2 +-
>  package/rtl8723bu/rtl8723bu.mk                      |  2 +-
>  3 files changed, 14 insertions(+), 2 deletions(-)
>  create mode 100644 package/rtl8723bu/0001-disable_concurent_mode.patch
> 
> diff --git a/package/rtl8723bu/0001-disable_concurent_mode.patch b/package/rtl8723bu/0001-disable_concurent_mode.patch
> new file mode 100644
> index 0000000000..037b1642fc
> --- /dev/null
> +++ b/package/rtl8723bu/0001-disable_concurent_mode.patch
> @@ -0,0 +1,12 @@
> +diff -purN a/Makefile b/Makefile
> +--- a/Makefile	2021-11-04 20:36:55.000000000 +0100
> ++++ b/Makefile	2022-01-10 14:35:17.333934039 +0100
> +@@ -18,7 +18,7 @@ EXTRA_CFLAGS += -Wno-unused-label
> + EXTRA_CFLAGS += -Wno-unused-parameter
> + EXTRA_CFLAGS += -Wno-unused-function
> + EXTRA_CFLAGS += -Wno-unused
> +-EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE
> ++#EXTRA_CFLAGS += -DCONFIG_CONCURRENT_MODE

When patching out unused code, don't comment it; just remove it.

Can you fix those two issues and resubmit, plese?

Regards,
Yann E. MORIN.

> + ccflags-y += -D__CHECK_ENDIAN__
> + 
> diff --git a/package/rtl8723bu/rtl8723bu.hash b/package/rtl8723bu/rtl8723bu.hash
> index 04bc776a07..df990a8d63 100644
> --- a/package/rtl8723bu/rtl8723bu.hash
> +++ b/package/rtl8723bu/rtl8723bu.hash
> @@ -1,2 +1,2 @@
>  # Locally computed
> -sha256  4c7314dccebda1e55ec8dcf0d5ca8915c2490d17a9f56923f25e6e0e945c10cc  rtl8723bu-9ce1c38439f4f574bb7adaf33949835c25536a28.tar.gz
> +sha256  c9cde757941c88c6117560a2c350dc9c4382dcd6a313b1cae7c6e7eade7055bf  rtl8723bu-d34603a39a7c925d810fe17c6e8dea5063d43a33.tar.gz
> diff --git a/package/rtl8723bu/rtl8723bu.mk b/package/rtl8723bu/rtl8723bu.mk
> index c35fad5832..e73987cfeb 100644
> --- a/package/rtl8723bu/rtl8723bu.mk
> +++ b/package/rtl8723bu/rtl8723bu.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RTL8723BU_VERSION = 9ce1c38439f4f574bb7adaf33949835c25536a28
> +RTL8723BU_VERSION = d34603a39a7c925d810fe17c6e8dea5063d43a33
>  RTL8723BU_SITE = $(call github,lwfinger,rtl8723bu,$(RTL8723BU_VERSION))
>  RTL8723BU_LICENSE = GPL-2.0, proprietary (*.bin firmware blobs)
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-10 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 15:13 [Buildroot] [PATCH 1/1] package/rtl8723bu: bump version to d34603a39a7c925d810fe17c6e8dea5063d43a33 Michael Fischer
2022-01-10 15:58 ` Yann E. MORIN [this message]
2022-01-11  8:36   ` Michael Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110155823.GS1477939@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    --cc=mf@go-sys.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox