From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/download: drop support for the 'none' hash
Date: Tue, 11 Jan 2022 21:58:59 +0100 [thread overview]
Message-ID: <20220111215859.15821eda@windsurf> (raw)
In-Reply-To: <20220110162319.294088-1-yann.morin.1998@free.fr>
On Mon, 10 Jan 2022 17:23:19 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Commit 1ba85b7f874d (support/download: add explicit no-hash support)
> introduced the 'none' hash type, in an attempt to make hash files
> mandatory, but not failing on archives localy generated, like those
> for git or svn repositories, especially for those packages where a
> version choice was present, which would allow for either remote
> archives for which we'd have a hash or VCS trees for which we could
> not have a hash for the localy generated archive.
>
> Indeed, back in the time, we did not have a mean to generate
> reproducible archives, so having a hash file without a hash for
> thosel ocally generated archives would trigger an error in the
> hash0-checking machinery.
>
> But now, low-and-behold, we do know how to generate those archives,
> and we have a mechanism to explicitly exclude some archives from being
> hash-checked (e.g. when the verison string itself can be user-provided).
>
> As such, the 'none' hash type no longer has any raison d'être, we do not
> use it in-tree, and its use in a br2-external tree is most probably
> inexistent (as is the use of hash files alotgether most probably).
>
> So we simply drop the support for that.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> docs/manual/adding-packages-directory.txt | 9 +--------
> support/download/check-hash | 4 ----
> 2 files changed, 1 insertion(+), 12 deletions(-)
Applied to master, with the fix suggested by Ricardo.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-11 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 16:23 [Buildroot] [PATCH] support/download: drop support for the 'none' hash Yann E. MORIN
2022-01-10 22:43 ` ricardo.martincoski
2022-01-11 20:59 ` Thomas Petazzoni
2022-01-11 20:58 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111215859.15821eda@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox