From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/riscv-isa-sim: new package
Date: Tue, 11 Jan 2022 23:08:08 +0100 [thread overview]
Message-ID: <20220111230808.5c9f298e@windsurf> (raw)
In-Reply-To: <20220109164756.1312023-1-ju.o@free.fr>
On Sun, 9 Jan 2022 17:47:55 +0100
Julien Olivain <ju.o@free.fr> wrote:
> Spike, the RISC-V ISA Simulator, implements a functional model of one
> or more RISC-V harts.
>
> The host package provides an alternative solution to qemu.
>
> https://github.com/riscv-software-src/riscv-isa-sim
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Thanks for your patch!
> diff --git a/package/Config.in b/package/Config.in
> index 85193f7802..b20cf45698 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2126,6 +2126,7 @@ menu "Miscellaneous"
> source "package/proj/Config.in"
> source "package/qemu/Config.in"
> source "package/qpdf/Config.in"
> + source "package/riscv-isa-sim/Config.in"
> source "package/rtl_433/Config.in"
> source "package/shared-mime-info/Config.in"
> source "package/sunwait/Config.in"
It wasn't clear to me what was the use-case/reasoning for having a
target variant of this package, so I've dropped the target variant and
kept only the host variant.
> diff --git a/package/riscv-isa-sim/0001-riscv-disable-precompiled-headers.patch b/package/riscv-isa-sim/0001-riscv-disable-precompiled-headers.patch
> new file mode 100644
> index 0000000000..461f34e3a1
> --- /dev/null
> +++ b/package/riscv-isa-sim/0001-riscv-disable-precompiled-headers.patch
> @@ -0,0 +1,34 @@
> +From 980d5143089bf32ef8a6dfdf1bb9e9fe92fa7bf5 Mon Sep 17 00:00:00 2001
> +From: Julien Olivain <ju.o@free.fr>
> +Date: Sun, 9 Jan 2022 13:38:48 +0100
> +Subject: [PATCH] riscv: disable precompiled headers
> +
> +While precompiling header, some toolchains fail with the message:
> +
> + /path/to/toolchain/bin/ld: /path/to/sysroot/usr/lib/Scrt1.o: in function `_start':
> + (.text+0x54): undefined reference to `main'
Has this been reported upstream? Will it be fixed upstream?
Anyway: patch applied to master, with the target variant dropped.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-11 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 16:47 [Buildroot] [PATCH 1/2] package/riscv-isa-sim: new package Julien Olivain
2022-01-09 16:47 ` [Buildroot] [PATCH 2/2] configs/spike_riscv64: new defconfig Julien Olivain
2022-01-11 22:08 ` Thomas Petazzoni
2022-01-11 22:08 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111230808.5c9f298e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox