From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "José Pekkarinen" <jose.pekkarinen@unikie.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/opensc: new package
Date: Thu, 13 Jan 2022 20:54:37 +0100 [thread overview]
Message-ID: <20220113205437.47e82728@windsurf> (raw)
In-Reply-To: <20220113114951.549960-1-jose.pekkarinen@unikie.com>
Hello José,
On Thu, 13 Jan 2022 13:49:51 +0200
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:
> diff --git a/package/opensc/Config.in b/package/opensc/Config.in
> new file mode 100644
> index 0000000000..5ee52d1de6
> --- /dev/null
> +++ b/package/opensc/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_OPENSC
> + bool "opensc"
> + depends on !BR2_STATIC_LIBS # dlopen()
> + depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
Unfortunately, this is not acceptable. If it breaks with this
particular toolchain, it's also likely to break with other toolchains
that share similar characteristics (gcc version, etc.).
> + select BR2_PACKAGE_PCSC_LITE
> + select BR2_PACKAGE_OPENSSL
> + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL
Why do you force OpenSSL here? Is LibreSSL confirmed to not work with
opensc? If so, please add a comment above this select that explains
what explain is broken.
If you select BR2_PACKAGE_PCSC_LITE, you also need to inherit its
dependencies, i.e:
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
depends on !BR2_STATIC_LIBS
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-13 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 11:49 [Buildroot] [PATCH v3] package/opensc: new package José Pekkarinen
2022-01-13 19:54 ` Thomas Petazzoni [this message]
2022-01-13 20:22 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2021-11-25 7:27 José Pekkarinen
2021-11-25 7:29 ` José Pekkarinen
2021-11-25 7:22 José Pekkarinen
2021-11-30 13:16 ` José Pekkarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113205437.47e82728@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=jose.pekkarinen@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox