Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Julien Olivain <ju.o@free.fr>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-gnupg: new package
Date: Thu, 13 Jan 2022 21:51:04 +0100	[thread overview]
Message-ID: <20220113215104.02a734a1@windsurf> (raw)
In-Reply-To: <20220110200151.830192-1-ju.o@free.fr>

Hello Julien,

On Mon, 10 Jan 2022 21:01:51 +0100
Julien Olivain <ju.o@free.fr> wrote:

>  DEVELOPERS                             |  1 +
>  package/Config.in                      |  1 +
>  package/python-gnupg/Config.in         | 15 +++++++++++++++
>  package/python-gnupg/python-gnupg.hash |  5 +++++
>  package/python-gnupg/python-gnupg.mk   | 13 +++++++++++++
>  5 files changed, 35 insertions(+)

Thanks for the patch, which I have applied, with a change (see below).
However, more importantly, could you write and contribute a test case
for python-gnupg in our runtime test infrastructure ? See
https://buildroot.org/downloads/manual/manual.html#_using_the_runtime_tests_framework
for some amount of details.

> +config BR2_PACKAGE_PYTHON_GNUPG
> +	bool "python-gnupg"
> +	select BR2_PACKAGE_GNUPG2 if !BR2_PACKAGE_GNUPG # runtime

This generates a circular dependency reported by kconfig, because
another package does exactly the opposite. So I have inverted the logic
here:

select BR2_PACKAGE_GNUPG if !BR2_PACKAGE_GNUPG2 # runtime

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-13 20:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 20:01 [Buildroot] [PATCH 1/1] package/python-gnupg: new package Julien Olivain
2022-01-13 20:51 ` Thomas Petazzoni [this message]
2022-01-16 10:55   ` Julien Olivain
2022-01-16 12:01     ` Arnout Vandecappelle
2022-01-23 15:34       ` Julien Olivain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113215104.02a734a1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox