Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Francis Laniel <flaniel@linux.microsoft.com>
Cc: Samuel Martin <s.martin49@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/2] linux: add BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE
Date: Thu, 13 Jan 2022 22:41:26 +0100	[thread overview]
Message-ID: <20220113224126.6b0801dd@windsurf> (raw)
In-Reply-To: <20211222174905.71902-3-flaniel@linux.microsoft.com>

Hello,

On Wed, 22 Dec 2021 18:49:05 +0100
Francis Laniel <flaniel@linux.microsoft.com> wrote:

> CONFIG_DEBUG_BTF_INFO relies on pahole, so kernel DWARF are converted to BTF.
> If CONFIG_DEBUG_BTF_INFO is set and BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE not,
> an error message is shown and .config is not written.
> 
> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>

Thanks, applied, with one change.

> diff --git a/package/pahole/Config.in.host b/package/pahole/Config.in.host
> index e427629632..521874961b 100644
> --- a/package/pahole/Config.in.host
> +++ b/package/pahole/Config.in.host
> @@ -3,4 +3,6 @@ config BR2_PACKAGE_HOST_PAHOLE
>  	help
>  	  Pahole and other DWARF utils.
>  
> +	  Select this if you want to build a kernel with CONFIG_DEBUG_INFO_BTF set.
> +

I've dropped this, because it's not really this option that should be
enabled if the kernel is configured with CONFIG_DEBUG_INFO_BTF, but the
BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE option.

Thanks for your contribution!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-13 21:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 17:49 [Buildroot] [PATCH v2 0/2] Enable BTF headers for Linux kernel Francis Laniel
2021-12-22 17:49 ` [Buildroot] [PATCH v2 1/2] package/pahole: new host package Francis Laniel
2022-01-13 21:40   ` Thomas Petazzoni
2021-12-22 17:49 ` [Buildroot] [PATCH v2 2/2] linux: add BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE Francis Laniel
2022-01-13 21:41   ` Thomas Petazzoni [this message]
2022-01-17 13:51     ` Francis Laniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113224126.6b0801dd@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=flaniel@linux.microsoft.com \
    --cc=s.martin49@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox