From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFE1FC433F5 for ; Thu, 13 Jan 2022 22:14:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 994A040A73; Thu, 13 Jan 2022 22:14:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qoD0y-mSdGJS; Thu, 13 Jan 2022 22:14:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id C13C740A71; Thu, 13 Jan 2022 22:14:43 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 95E7A1BF476 for ; Thu, 13 Jan 2022 22:14:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 84460415CD for ; Thu, 13 Jan 2022 22:14:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NzN3vylmcMH4 for ; Thu, 13 Jan 2022 22:14:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0174F415B9 for ; Thu, 13 Jan 2022 22:14:40 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 48B73100002; Thu, 13 Jan 2022 22:14:39 +0000 (UTC) Date: Thu, 13 Jan 2022 23:14:38 +0100 From: Thomas Petazzoni To: Fabrice Fontaine Message-ID: <20220113231438.5aa8742e@windsurf> In-Reply-To: <20211121145741.1fa4dffb@windsurf> References: <20211119175553.2413433-1-fontaine.fabrice@gmail.com> <20211121145741.1fa4dffb@windsurf> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH v2, 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hello Fabrice, On Sun, 21 Nov 2021 14:57:41 +0100 Thomas Petazzoni wrote: > On Fri, 19 Nov 2021 18:55:52 +0100 > Fabrice Fontaine wrote: > > > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > > these selects on boost side as the build failure was raised with gcc >= > > 7 (making this commit a "no-op"). Indeed, the build failure is raised > > with cmake < 3.21.3, because cmake assumed that boost thread depends on > > date-time until > > https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. > > I don't understand why you say this commit is a no-op. It clearly > isn't. In gcc < 7.x configurations, this commit ensures that boost > chrono and boost date-time are selected. > > The fact that you realize later that the build failure occurred with > gcc >= 7.x, meaning this commit does not help fixing the issue does not > make this commit a no-op. Do you have some feedback/comment on the above questions? Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot