From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/boost: enable system on host
Date: Sat, 15 Jan 2022 10:49:25 +0100 [thread overview]
Message-ID: <20220115094925.GF1945846@scaer> (raw)
In-Reply-To: <20220114171847.634174-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2022-01-14 18:18 +0100, Fabrice Fontaine spake thusly:
> boost system (which provides boost asio) is needed by host-riscv-isa-sim
> since its addition in commit ea033cecf990ed3f86619647523a9ad2ccb09adb:
>
> configure: error: Could not find a version of the Boost::Asio library!
>
> Fixes:
> - http://autobuild.buildroot.org/results/6c33a66386ab2171454d8ea8c1bd17a5582e21dd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/boost/boost.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/boost/boost.mk b/package/boost/boost.mk
> index 6d1046e9a2..2d2a8fb311 100644
> --- a/package/boost/boost.mk
> +++ b/package/boost/boost.mk
> @@ -17,7 +17,7 @@ HOST_BOOST_FLAGS = --without-icu --with-toolset=gcc \
> --without-libraries=$(subst $(space),$(comma),atomic chrono context \
> contract container coroutine date_time exception fiber filesystem graph \
> graph_parallel iostreams json locale log math mpi nowide program_options \
> - python random serialization stacktrace system test thread timer \
> + python random serialization stacktrace test thread timer \
> type_erasure wave)
I was wondering why we need to disable those, and the original commit
log is not very explicit about why this is so (429ffbd2253 boost: add
host variant), and the comment is not very helpful either...
So I did a test: remove all those exclusion (just exclude python [0]),
and build just host-boost (it has no dependency):
master : 54s
no-exclusion: 2min 38s
So yes, this is a big increase. But considering that we have no way for
host packages to express dependencies on Boost features, I wonder if we
should not just build the whole stuff. For example, packages in a
br2-external have no way to say so...
Anyway, in the meantime: applied to master, thanks.
[0] building the Boost python module would require the python development
files be installed on the host, or that we depend on host-python{,3},
neither of which are acceptable
Regards,
Yann E. MORIN.
> BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_ATOMIC),,atomic)
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-15 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 17:18 [Buildroot] [PATCH 1/1] package/boost: enable system on host Fabrice Fontaine
2022-01-15 9:49 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115094925.GF1945846@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox