Re: [Buildroot] package/vte: add libvte to buildroot toolchain

["Yann E. MORIN" <yann.morin.1998@free.fr>]

rainbox2k12, All,

On 2022-01-15 10:14 +0000, rainbox2k12 via buildroot spake thusly:
> This patch is needed in order to use libvte in the buildroot toolchain.

Thanks for your contribution; it definitely makes sense.

To accept patches in Buildroot, we need them to be properly authored to
a real name. Additionally, patches should have a sign-off that matches
the author of the patch.

Patches should also be properly formatted with a title and a
description.

In this case, a appropriate commit-log should probably look like:

    package/vte: install to staging

    vte also provides libvte, a library that can be linked to by other
    programs, so install it in staging.

    Signed-off-by: Your Real NAME <your-email>

See the manual for more details:
    https://buildroot.org/downloads/manual/manual.html#submitting-patches

> diff --git a/package/vte/vte.mk b/package/vte/vte.mk
> 
> index 07e8136..ceb2f09 100644
> 
> --- a/package/vte/vte.mk
> 
> +++ b/package/vte/vte.mk
> 
> @@ -11,6 +11,7 @@ VTE_SITE = http://ftp.gnome.org/pub/gnome/sources/vte/$(VTE_VERSION_MAJOR)
> 
>  VTE_DEPENDENCIES = host-pkgconf libgtk3 pcre2 $(TARGET_NLS_DEPENDENCIES)
> 
>  VTE_LICENSE = LGPL-3.0+
> 
>  VTE_LICENSE_FILES = COPYING.LGPL3
> 
> +VTE_INSTALL_STAGING = YES

This patch is heavily mangled by your mailer. Please use 'git send-email'
to send patches; this ensures that patches are properly formatted in a
mail ready to be applied by maintainers.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_PACKAGE_ICU),y)
> 
>  VTE_CONF_OPTS += -Dicu=true
> 
> --
> Sent using [1]MsgSafe.io's Free Plan
> Private, encrypted, online communication
> For everyone. [2]www.msgsafe.io
> 
> Links:
> 1. file:///tmp/mail-html2txt.2089315.NQ2C0Z/https:/www.msgsafe.io/?utm_source=msgsafe&utm_medium=email&utm_campaign=freemailsignature
> 2. file:///tmp/mail-html2txt.2089315.NQ2C0Z/https:/www.msgsafe.io/?utm_source=msgsafe&utm_medium=email&utm_campaign=freemailsignature

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot