Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Julien Olivain <ju.o@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/riscv-isa-sim: set --with-boost
Date: Wed, 19 Jan 2022 21:23:51 +0100	[thread overview]
Message-ID: <20220119202351.GA3095239@scaer> (raw)
In-Reply-To: <20220115160449.2292472-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-01-15 17:04 +0100, Fabrice Fontaine spake thusly:
> Set --with-boost to avoid the following build failure when a non working
> boost version is installed on host. This failure is raised since the
> addition of the package in commit
> ea033cecf990ed3f86619647523a9ad2ccb09adb:
> 
> configure:5559: error: Could not find a version of the Boost::Asio library!
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/855b66b86d979cc922b947da932b0e2388481263
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/riscv-isa-sim/riscv-isa-sim.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/riscv-isa-sim/riscv-isa-sim.mk b/package/riscv-isa-sim/riscv-isa-sim.mk
> index ee9067d304..90eed93c36 100644
> --- a/package/riscv-isa-sim/riscv-isa-sim.mk
> +++ b/package/riscv-isa-sim/riscv-isa-sim.mk
> @@ -9,5 +9,6 @@ RISCV_ISA_SIM_SITE = $(call github,riscv-software-src,riscv-isa-sim,v$(RISCV_ISA
>  RISCV_ISA_SIM_LICENSE = BSD-3-Clause
>  RISCV_ISA_SIM_LICENSE_FILES = LICENSE
>  HOST_RISCV_ISA_SIM_DEPENDENCIES = host-boost host-dtc
> +HOST_RISCV_ISA_SIM_CONF_OPTS = --with-boost=$(HOST_DIR)

To be noted: riscv-isa-sim could also be configured with --without-boost
and the build succeeds.

Anyway: applied to master, thanks.

Julien, do you know what ill-effect building without Boost would have?

Regards,
Yann E. MORIN.

>  $(eval $(host-autotools-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-19 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-15 16:04 [Buildroot] [PATCH 1/1] package/riscv-isa-sim: set --with-boost Fabrice Fontaine
2022-01-19 20:23 ` Yann E. MORIN [this message]
2022-01-23 20:03   ` Julien Olivain
2022-01-23 20:51     ` Yann E. MORIN
2022-01-24 18:47       ` Julien Olivain
2022-01-24 21:23         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220119202351.GA3095239@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox