From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Peter Seiderer <ps.report@gmx.net>,
buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/re2: switch to generic-package make build
Date: Fri, 21 Jan 2022 08:41:41 +0100 [thread overview]
Message-ID: <20220121084141.6eac525e@windsurf> (raw)
In-Reply-To: <20220121065850.GF3252931@scaer>
On Fri, 21 Jan 2022 07:58:50 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> So, I think that Peter's proposal is not so un-appealing, in then end.
> But then in such situation, I think it would be simpler for us to just
> apply something like:
>
> define RE2_INSTALL_PC
> $(INTALL) -d -m 0644 $(@D)/re2.pc \
> $(STAGING_DIR)/usr/lib/pkgconfig/re2.pc
> $(SED) 's,@includedir@,/usr/include,; s,@libdir@,/usr/lib,' \
> $(STAGING_DIR)/usr/lib/pkgconfig/re2.pc
> endef
> RE2_POST_STAGING_INSTALL_HOOKS += RE2_INSTALL_PC
>
> And be done with it: minimal change to the re2 package, no dual-buildsystem
> situation and thus no install conflict on the headers, usual and simple
> post-install hook.
I might be missing something in the whole discussion, but why not patch
the CMake build system so that it also installs this .pc file, and
contribute this fix upstream ?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-21 7:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 8:45 [Buildroot] [PATCH 1/1] package/re2: switch to generic-package make build James Hilliard
2022-01-19 20:45 ` Yann E. MORIN
2022-01-20 0:42 ` James Hilliard
2022-01-20 21:29 ` Peter Seiderer
2022-01-20 23:57 ` James Hilliard
2022-01-21 6:58 ` Yann E. MORIN
2022-01-21 7:41 ` Thomas Petazzoni [this message]
2022-01-21 7:59 ` Yann E. MORIN
2022-01-21 13:26 ` Thomas Petazzoni
2022-01-21 21:16 ` James Hilliard
2022-01-21 9:17 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121084141.6eac525e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=ps.report@gmx.net \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox