Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/htpdate: bump to version 1.3.3
Date: Fri, 21 Jan 2022 21:39:46 +0100	[thread overview]
Message-ID: <20220121203946.GI3252931@scaer> (raw)
In-Reply-To: <20220120211941.1033249-1-angelo@amarulasolutions.com>

Angelo, All,

On 2022-01-20 22:19 +0100, Angelo Compagnucci spake thusly:
> Update project to its new location and move to use the package provided
> init scripts.

The service file we provide is functional (it uses Google's server)
when the upstream service file is not (it uses a dymmy server), same
goes for the init script: we are trying to provide works-out-of-the-box
experience with sensible defaults. [0]

However, the upstream files are very similar to ours, and I see you were
the one to push them upstream.

[0] And of course, I had to test: https://example.com/ does exist, and
does return a date tag.

Meh, scratch all the above...

Still, I am not too fond of that, because then it means we are departing
from our customs to provide our own scripts in all packages...

Oh damn, I am not sure... But that is not the biggest issue, see
below...

> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
[--SNIP--]
> diff --git a/package/htpdate/htpdate.mk b/package/htpdate/htpdate.mk
> index e9323f9106..3c4412b283 100644
> --- a/package/htpdate/htpdate.mk
> +++ b/package/htpdate/htpdate.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -HTPDATE_VERSION = 1.3.1
> +HTPDATE_VERSION = 1.3.3

Er... We have 1.2.6 in the tree, and I could not find the 1.2.6 -> 1.3.1
bump in Patchwork... Are you sure you prepared your patch against
master?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-21 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 21:19 [Buildroot] [PATCH] package/htpdate: bump to version 1.3.3 Angelo Compagnucci
2022-01-21 20:39 ` Yann E. MORIN [this message]
2022-01-21 20:44   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220121203946.GI3252931@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=angelo@amarulasolutions.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox