From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Geoffrey Ragot <geoffreyragot@gmail.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-pyyaml: bump to version 6.0
Date: Wed, 26 Jan 2022 23:00:25 +0100 [thread overview]
Message-ID: <20220126230025.67670779@windsurf> (raw)
In-Reply-To: <20220124111725.544497-1-james.hilliard1@gmail.com>
On Mon, 24 Jan 2022 04:17:25 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> Drop python2 support and propagate dependency changes.
>
> Ensure optimized cython build is enabled and add host cython
> dependency.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/libcamera/libcamera.mk | 2 +-
> package/mongodb/mongodb.mk | 2 +-
> package/python-pyyaml/Config.in | 1 +
> package/python-pyyaml/python-pyyaml.hash | 4 ++--
> package/python-pyyaml/python-pyyaml.mk | 9 +++++----
> package/python3-pyyaml/python3-pyyaml.hash | 1 -
> package/python3-pyyaml/python3-pyyaml.mk | 20 --------------------
> 7 files changed, 10 insertions(+), 29 deletions(-)
> delete mode 120000 package/python3-pyyaml/python3-pyyaml.hash
> delete mode 100644 package/python3-pyyaml/python3-pyyaml.mk
Applied to master, thanks. I was surprised by the usage of
host-python-pyyaml by host-sdbusplus. Indeed, host-sdbusplus depends on
host-python3 and host-python-pyyaml, the latter being (before your
patch) forcefully build for Python 2.x.
So of the 3 Python modules that host-sdbusplus needs (inflection, mako,
pyyaml), inflection and mako were installed for the host Python 3.x
interpreter, and host-python-pyyaml for the host Python 2.x
interpreter. And the host-sdbusplus build, even though it depended on
host-python3, was in fact using host Python 2.x... which raises a
question on the actual need of host-python-inflection and
host-python-mako... as they are not actually needed during the build:
the build succeeds when host-sdbusplus uses host Python 2.x, while mako
and inflection are installed for host Python 3.x.
It seems like they are only used at runtime ? But that also wouldn't
work.
Anyway, now with host-python-pyyaml being python3 only, this kind of
solves the problem. But perhaps host-sdbusplus should be explicitly
told to use $(HOST_DIR)/bin/python3, because if $(HOST_DIR)/bin/python2
is here, it will use it, and it won't have access to pyyaml.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-26 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 11:17 [Buildroot] [PATCH 1/1] package/python-pyyaml: bump to version 6.0 James Hilliard
2022-01-26 22:00 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126230025.67670779@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=geoffreyragot@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox