Re: [Buildroot] [PATCH v3 1/2] package/runc: add host package

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello,

On Wed, 26 Jan 2022 22:25:03 -0800
Christian Stewart <christian@paral.in> wrote:

> diff --git a/package/runc/runc.mk b/package/runc/runc.mk
> index c4e45a00a9..932bf39eea 100644
> --- a/package/runc/runc.mk
> +++ b/package/runc/runc.mk
> @@ -10,6 +10,8 @@ RUNC_LICENSE = Apache-2.0
>  RUNC_LICENSE_FILES = LICENSE
>  RUNC_CPE_ID_VENDOR = linuxfoundation
>  
> +RUNC_GOMOD = github.com/opencontainers/runc

How is this related to  the addition of the host package? This seems
unrelated. Why is this needed now?

> +HOST_RUNC_BIN_NAME = runc

Why is this not needed for the target package ?

> +HOST_RUNC_LDFLAGS = $(RUNC_LDFLAGS)
> +HOST_RUNC_TAGS = $(RUNC_TAGS)
> +HOST_RUNC_INSTALL_BINS = $(HOST_RUNC_BIN_NAME)

This makes me think we should probably have some inheritance of those
variables between the target variant and the host variant of the
package.

However, HOST_RUNC_TAGS = $(RUNC_TAGS) looks most likely wrong. Indeed:

ifeq ($(BR2_PACKAGE_LIBAPPARMOR),y)
RUNC_DEPENDENCIES += libapparmor
RUNC_TAGS += apparmor
endif

ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
RUNC_TAGS += seccomp
RUNC_DEPENDENCIES += libseccomp host-pkgconf
endif

and you most likely don't want HOST_RUNC_TAGS to contain apparmor or
seccomp, because we are not building libseccomp or libapparmor for the
host.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot