Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Jonathan Borne <jborne@kalray.eu>
Cc: ysionneau@kalray.eu, jmaselbas@kalray.eu, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/binutils: remove libiberty from target install
Date: Thu, 27 Jan 2022 22:18:19 +0100	[thread overview]
Message-ID: <20220127211819.GR457876@scaer> (raw)
In-Reply-To: <20220127135339.25430-2-jborne@kalray.eu>

Jonathan, All,

Thanks for this new iteration. :-)

On 2022-01-27 14:53 +0100, Jonathan Borne via buildroot spake thusly:
> In BINUTILS_INSTALL_TARGET_CMDS, libiberty is installed
> to STAGING_DIR
> 
> This is not necessary since libiberty is already
> unconditionally installed to staging in
> BINUTILS_INSTALL_STAGING_CMDS. Furthermore the presence
> of STAGING_DIR path in TARGET_CMDS is confusing.
> 
> Moreover libiberty is static only. Static libraries
> are only used at build time, not at run time so
> we do not want to install libiberty on target.
> 
> This commit removes the unnecessary libiberty
> install in TARGET_CMDS and add a comment to clarify
> why we do not see libiberty installed on target.

I've slightly reworded the commit log, and rewrapped it closer to the
usual 72-char width.

> Signed-off-by: Jonathan Borne <jborne@kalray.eu>
> ---
>  package/binutils/binutils.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index 13f61be035..32ca70d325 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
> @@ -95,6 +95,8 @@ BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
>  
>  # We just want libbfd, libiberty and libopcodes,
>  # not the full-blown binutils in staging
> +# Static-only libraries such as libiberty are used at buildtime in staging
> +# but are not installed to target.

I believe the comment in fact makes more sense closer to the
_ISNTALL_TARGET_CMDS, so I moved it there, and reworded it
appropriately.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  define BINUTILS_INSTALL_STAGING_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(STAGING_DIR) install
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(STAGING_DIR) install
> @@ -106,7 +108,6 @@ ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)
>  define BINUTILS_INSTALL_TARGET_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install
> -	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
>  endef
>  endif
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-27 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 13:53 [Buildroot] [PATCH 0/1] remove libiberty from target install Jonathan Borne via buildroot
2022-01-27 13:53 ` [Buildroot] [PATCH 1/1] package/binutils: " Jonathan Borne via buildroot
2022-01-27 21:18   ` Yann E. MORIN [this message]
2022-01-28  9:15     ` Jonathan Borne via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220127211819.GR457876@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=jborne@kalray.eu \
    --cc=jmaselbas@kalray.eu \
    --cc=ysionneau@kalray.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox