From: Romain Naour <romain.naour@gmail.com>
To: buildroot@buildroot.org
Cc: Romain Naour <romain.naour@gmail.com>
Subject: [Buildroot] [PATCH 2/3] package/poke: disable minimal-threading with thumb or thumb2
Date: Sat, 29 Jan 2022 15:23:51 +0100 [thread overview]
Message-ID: <20220129142352.1197168-2-romain.naour@gmail.com> (raw)
In-Reply-To: <20220129142352.1197168-1-romain.naour@gmail.com>
Disable minimal-threading when thumb or thumb2 is enabled due to build and runtime issues.
After fixing the build issue "Error: invalid swi expression" with
upstream, poke fail to run with the following error:
# poke
ERROR: specialized instruction beghl/retR (opcode 25) is defective but has no replacement
[...]
Fixes:
https://gitlab.com/kubu93/buildroot/-/jobs/2030046871
Reported upstream [1].
[1] https://lists.gnu.org/archive/html/poke-devel/2022-01/msg00162.html
Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
package/poke/poke.mk | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/package/poke/poke.mk b/package/poke/poke.mk
index ddd03ae3b0..91518f5854 100644
--- a/package/poke/poke.mk
+++ b/package/poke/poke.mk
@@ -46,6 +46,15 @@ POKE_CONF_OPTS = \
--disable-libnbd \
--with-libreadline-prefix=$(STAGING_DIR)
+# Disable minimal-threading when thumb or thumb2 is enabled
+# due to runtime issue.
+# https://lists.gnu.org/archive/html/poke-devel/2022-01/msg00162.html
+ifeq ($(BR2_ARM_CPU_HAS_THUMB)$(BR2_ARM_CPU_HAS_THUMB2),y)
+POKE_CONF_OPTS += --disable-dispatch-minimal-threading
+else
+POKE_CONF_OPTS += --enable-dispatch-minimal-threading
+endif
+
ifeq ($(BR2_PACKAGE_JSON_C),y)
POKE_DEPENDENCIES += json-c
POKE_CONF_OPTS += --enable-mi
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-29 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 14:23 [Buildroot] [PATCH 1/3] package/poke: install libpoke.so to staging Romain Naour
2022-01-29 14:23 ` Romain Naour [this message]
2022-01-30 14:46 ` [Buildroot] [PATCH 2/3] package/poke: disable minimal-threading with thumb or thumb2 Thomas Petazzoni via buildroot
2022-01-30 17:32 ` Romain Naour
2022-01-29 14:23 ` [Buildroot] [PATCH 3/3] package/poke: bump to version 2.0 Romain Naour
2022-01-30 14:28 ` [Buildroot] [PATCH 1/3] package/poke: install libpoke.so to staging Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129142352.1197168-2-romain.naour@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox