From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-cargo: fix debug build
Date: Sun, 30 Jan 2022 15:55:59 +0100 [thread overview]
Message-ID: <20220130155559.11d4fea3@windsurf> (raw)
In-Reply-To: <20220129094222.3583303-1-fontaine.fabrice@gmail.com>
On Sat, 29 Jan 2022 10:42:22 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> There is no --debug mode for cargo resulting in the following build
> failure in ripgrep since its conversion to cargo infrastructure in
> commit 342fd3e7350479dc368541ac77a5130ebb53194c:
>
> error: Found argument '--debug' which wasn't expected, or isn't valid in this context
>
> Fixes:
> - http://autobuild.buildroot.org/results/772ebdd6a39950457a59419bdc1376cb0e0a3611
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/pkg-cargo.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
However, I'm wondering if we shouldn't instead use:
--profile=release
and
--profile=dev
See https://doc.rust-lang.org/cargo/reference/profiles.html
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-30 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 9:42 [Buildroot] [PATCH 1/1] package/pkg-cargo: fix debug build Fabrice Fontaine
2022-01-30 14:55 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130155559.11d4fea3@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox