From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/htpdate: fix static openssl build
Date: Sun, 30 Jan 2022 16:02:58 +0100 [thread overview]
Message-ID: <20220130160258.20d80a8d@windsurf> (raw)
In-Reply-To: <20220129104425.3724653-1-fontaine.fabrice@gmail.com>
On Sat, 29 Jan 2022 11:44:25 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following static build failure with openssl raised since bump to
> version 1.3.3 in commit 163509a8e0d558e6339c5489f072dfe805e0cc34:
>
> /home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sh4-buildroot-linux-uclibc/10.3.0/../../../../sh4-buildroot-linux-uclibc/bin/ld: /home/buildroot/autobuild/instance-3/output-1/host/sh4-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a(rec_layer_d1.o): in function `DTLS_RECORD_LAYER_new':
> rec_layer_d1.c:(.text+0x124): undefined reference to `CRYPTO_malloc'
>
> Fixes:
> - http://autobuild.buildroot.org/results/75ad8515916dfa056b17c97fdd95c7eb4d83a304
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
> - Move pkg-config call in htpdate.mk following upstream feedback:
> https://github.com/twekkel/htpdate/pull/17
I'm a bit surprised by your feedback to upstream's reaction. Indeed, it
would have been possible in the Makefile to make use of pkg-config if
it's available, and if not fallback to just using -lssl. Preserve the
existing behavior, doesn't make pkg-config mandatory, but allows people
like use to make use of pkg-config.
Anyway, I've applied your patch as-is. And it made me wonder why
host-pkgconf was already part of the package dependencies?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-30 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 10:44 [Buildroot] [PATCH v2, 1/1] package/htpdate: fix static openssl build Fabrice Fontaine
2022-01-30 15:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130160258.20d80a8d@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo.compagnucci@gmail.com \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox