From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/2] configs/beelink_gs1: increase rootfs size to 120M
Date: Sun, 30 Jan 2022 18:18:30 +0100 [thread overview]
Message-ID: <20220130181830.3170d14f@windsurf> (raw)
In-Reply-To: <20220129111731.736265-1-peron.clem@gmail.com>
On Sat, 29 Jan 2022 12:17:30 +0100
Clément Péron <peron.clem@gmail.com> wrote:
> For the moment Beelink GS1 use a default rootfs size of 60M,
> which is a bit low if you want to add some packages like a
> graphic stack.
>
> Increase the rootfs size to 120M.
>
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> configs/beelink_gs1_defconfig | 1 +
> 1 file changed, 1 insertion(+)
I have not applied this one. Indeed, any defconfig that uses the
default rootfs size of 60M would have the problem of "if I add more
packages, it doesn't fit in the image". The defconfigs are meant to be
minimal, so it doesn't make sense to increase the size to 120M to
accommodate some possible package additions. Maybe even 120M is not
going to be enough depending on how many packages you add (and how
large they are).
So I've marked this patch as Rejected.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-30 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 11:17 [Buildroot] [PATCH v2 1/2] configs/beelink_gs1: increase rootfs size to 120M Clément Péron
2022-01-29 11:17 ` [Buildroot] [PATCH v2 2/2] configs/beelink_gs1: bump to linux 5.15, atf 2.5 and u-boot 2021.10 Clément Péron
2022-01-29 11:22 ` Giulio Benetti
2022-01-30 17:16 ` Thomas Petazzoni via buildroot
2022-01-30 17:18 ` Thomas Petazzoni via buildroot [this message]
2022-01-31 12:43 ` [Buildroot] [PATCH v2 1/2] configs/beelink_gs1: increase rootfs size to 120M Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130181830.3170d14f@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=peron.clem@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox