From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@buildroot.org
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [Buildroot] [PATCH v1] package/libcamera: fix uclibc/musl compile with libexecinfo enabled
Date: Tue, 1 Feb 2022 23:32:47 +0100 [thread overview]
Message-ID: <20220201233247.28ac615b@gmx.net> (raw)
In-Reply-To: <20220131230730.22235-1-ps.report@gmx.net>
On Tue, 1 Feb 2022 00:07:30 +0100, Peter Seiderer <ps.report@gmx.net> wrote:
> - depend and link against libexecinfo if enabled to fix linking failure
> in case execinfo.h is detected, see
> libcamera-40f5fddca7f774944a53f58eeaebc4db79c373d8/meson.build:
>
> 32 if cc.has_header_symbol('execinfo.h', 'backtrace')
> 33 config_h.set('HAVE_BACKTRACE', 1)
> 34 endif
>
> - libexecinfo already depends on !BR2_TOOLCHAIN_USES_GLIBC
>
> Fixes:
>
> - http://autobuild.buildroot.net/results/a1077815895ab847c5ca82ec17c7d13fe97cff53
>
> .../powerpc-buildroot-linux-uclibc/bin/ld: src/libcamera/base/libcamera-base.so.p/log.cpp.o: in function `libcamera::Logger::backtrace()':
> log.cpp:(.text+0x34b0): undefined reference to `backtrace'
> .../powerpc-buildroot-linux-uclibc/bin/ld: log.cpp:(.text+0x34c0): undefined reference to `backtrace_symbols'
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/libcamera/libcamera.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index 524cf07e03..9be45d248a 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -99,4 +99,9 @@ else
> LIBCAMERA_CONF_OPTS += -Dtracing=disabled
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
> +LIBCAMERA_DEPENDENCIES += libexecinfo
> +LIBCAMERA_LDFLAGS += -lexecinfo
Should be:
LIBCAMERA_LDFLAGS = $(TARGET_LDFLAGS) -lexecinfo
Updated patch will follow...
Regards,
Peter
> +endif
> +
> $(eval $(meson-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-02-01 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 23:07 [Buildroot] [PATCH v1] package/libcamera: fix uclibc/musl compile with libexecinfo enabled Peter Seiderer
2022-02-01 22:32 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201233247.28ac615b@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@buildroot.org \
--cc=kieran.bingham@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox