From: Daniil Stas <daniil.stas@posteo.net>
To: buildroot@buildroot.org
Cc: Sergey Matyukevich <geomatsi@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [Buildroot] [BUG] boot/arm-trusted-firmware: Stack protection setting doesn't work
Date: Sun, 6 Feb 2022 00:07:11 +0000 [thread overview]
Message-ID: <20220206020711.3dc6e42e@ux550ve> (raw)
The bug was introduced in commit ccac9a5bbb
("boot/arm-trusted-firmware: don't force ENABLE_STACK_PROTECTOR").
In this commit the ENABLE_STACK_PROTECTOR option was moved from make
arguments to the environment. But this value gets overwritten in
make_helpers/defaults.mk (and platform specific makefiles) before it
gets handled in the lib/stack_protector/stack_protector.mk.
So setting it via environment doesn't work.
You can check it, for example, if you compile TF-A for stm32mp157a_dk1
platform, and then check if bl32/stack_protector.o file is
built.
It gets built only with commit ccac9a5bbb being reverted.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2022-02-06 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 0:07 Daniil Stas [this message]
2022-02-06 18:43 ` [Buildroot] [BUG] boot/arm-trusted-firmware: Stack protection setting doesn't work Baruch Siach via buildroot
2022-02-06 20:47 ` Daniil Stas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206020711.3dc6e42e@ux550ve \
--to=daniil.stas@posteo.net \
--cc=buildroot@buildroot.org \
--cc=geomatsi@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox