From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37521C433F5 for ; Wed, 9 Feb 2022 19:54:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9DF0760B98; Wed, 9 Feb 2022 19:54:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VFcN01hoWzQv; Wed, 9 Feb 2022 19:54:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id DE1AA60B4E; Wed, 9 Feb 2022 19:54:15 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 915C41BF422 for ; Wed, 9 Feb 2022 19:54:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8D43D4021F for ; Wed, 9 Feb 2022 19:54:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=bootlin.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7mBo-9kEAJ49 for ; Wed, 9 Feb 2022 19:54:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by smtp4.osuosl.org (Postfix) with ESMTPS id 438C340138 for ; Wed, 9 Feb 2022 19:54:13 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 716E0240007; Wed, 9 Feb 2022 19:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1644436451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zkqVzvdH2gqdgBzCm8iKXzzpm6XIXJ6EeEj8xY3W9H0=; b=cZ8wG1qgq0drfSJIRyZShWozhfhZ20WjmXt8mHt+vAvodUBmh8CJXCttvCRj2sWYI9z9+4 zeFn22BrJ5QKLbKl3yG1R59toF7BET5TIz3HBC1XziFfcv/ITlIU0nlx+YgVM6NjuzxzcY pKBE8phSGkyWmBTUpigWfdRx5clpE/A9OJMwkZs2H7CtTT9e01DJ3NPdBCFsa8W3HFR5F1 0HG6gh70VfcLmzj5oanrIfv6k6pG4QLcbnwWUM2Mo3PqIITNtCgh1QsRW0h4kdKS+g0CLL WSgS0cDUYJGCSKzRC5TLg9XJT+P3UnPGnGAaaDfX1L1/zHDXrC/5sLVWkXs0NA== Date: Wed, 9 Feb 2022 20:54:10 +0100 To: Message-ID: <20220209205410.071f193a@windsurf> In-Reply-To: <20175_1644422934_6203E716_20175_175_1_fea7d1545892211e01cb6660dc5fba16b0851c47.1644422916.git.yann.morin@orange.com> References: <20175_1644422934_6203E716_20175_175_1_fea7d1545892211e01cb6660dc5fba16b0851c47.1644422916.git.yann.morin@orange.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 2/5 v2] package/pkg-cargo: allow building in a sub-directory X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Wed, 9 Feb 2022 17:08:44 +0100 wrote: > +# If building in a sub directory, use that to find the Cargo.toml, unless > +# the package already provided its location. > +ifneq ($$($(2)_SUBDIR),) > +ifeq ($$(filter BR_CARGO_MANIFEST_PATH=%,$$($(2)_DL_ENV)),) > +$(2)_DL_ENV += BR_CARGO_MANIFEST_PATH=$$($(2)_SUBDIR)/Cargo.toml I find that a bit "meh". Should we have an explicit package variable that tells the location of the Cargo.toml, instead of directly have packages pass this "magic" BR_CARGO_MANIFEST_PATH variable ? Should $(2)_SUBDIR be documented for the cargo-package infra in the documentation ? Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot