Re: [Buildroot] [PATCH v2, 1/2] package/gdk-pixbuf: enable relocatable option

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fabrice, All,

On 2022-02-20 13:16 +0100, Fabrice Fontaine spake thusly:
> Enable relocatable option to fix the following PPD build failure of
> adwaita-icon-theme:
> 
> Can't load file: Unrecognized image file format
> 
> This failure is raised because the SVG library is not found by
> gtk-encode-symbolic-svg. To find the SVG library,
> gtk-encode-symbolic-svg depends on libgtk_pixbuf library which reads the
> loaders.cache file using:
> - a hardcoded path (which points to host-gdk-pixbuf per-package
>   directory) if relocatable is disabled. The loaders.cache in this
>   directory doesn't declare SVG support because it has not yet been
>   updated by host-librsvg
> - or a dynamic path corresponding to the binary location if relocatable
>   is enabled.
> 
> So obviously, we need to set relocatable to true.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/0e00059b09b4445eaaec1030997883187c6a80d6

Thanks for providing more details, this is much better indeed, thanks! :-)

I've still felt the need to extend the commit log, because I found that
it left out some information adn explanations that may b needed in the
future.

Applied to master, thanks! :-)

Regards,
Yann E. MORIN.

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
>  - Drop relocatable from target
>  - Enhance commit message
> 
>  package/gdk-pixbuf/gdk-pixbuf.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk
> index cd30d450d5..b22e9568c9 100644
> --- a/package/gdk-pixbuf/gdk-pixbuf.mk
> +++ b/package/gdk-pixbuf/gdk-pixbuf.mk
> @@ -26,6 +26,7 @@ HOST_GDK_PIXBUF_CONF_OPTS = \
>  	-Dgio_sniffing=false \
>  	-Dinstalled_tests=false \
>  	-Dintrospection=disabled \
> +	-Drelocatable=true \
>  	-Dman=false
>  
>  ifeq ($(BR2_STATIC_LIBS),y)
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot