From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: John Keeping <john@metanate.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH] package/libiberty: use the same version as binutils
Date: Wed, 23 Feb 2022 15:51:41 +0100 [thread overview]
Message-ID: <20220223155141.0223462b@windsurf> (raw)
In-Reply-To: <20220223142731.GA189337@scaer>
On Wed, 23 Feb 2022 15:27:31 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Although this works, this is by pure chance: binutils is included before
> libiberty, so BINUTILS_VERSION is defined. But we try and avoid such a
> situation, unless we explicitly guarantee the include ordering (eg. gcc,
> fftw, util-linux, or previously, qt5).
>
> Instead, in such a case, we prefer that the version strin is duplicated,
> and a comment added above to note that both shoujld be updated in sync.
> See for example bluez5_utils and bluez5_utils-headers, mesa3d and
> mesa3d-headers.
libiberty/binutils is different than mesa3d or bluez5_utils, as the
version is user-selectable, or even different depending on the selected
CPU architecture.
So we would have to replicate all the version selection logic (like we
admittedly do for linux vs. linux-headers).
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-23 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 11:55 [Buildroot] [RFC PATCH] package/libiberty: use the same version as binutils John Keeping
2022-02-23 14:27 ` Yann E. MORIN
2022-02-23 14:51 ` Thomas Petazzoni via buildroot [this message]
2022-02-23 15:17 ` Yann E. MORIN
2022-02-23 16:39 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223155141.0223462b@windsurf \
--to=buildroot@buildroot.org \
--cc=john@metanate.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox