From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kamel Bouhara via buildroot <buildroot@buildroot.org>
Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [Buildroot] [PATCH 4/4] package/libodb-boost: add host variant
Date: Sat, 26 Feb 2022 11:35:38 +0100 [thread overview]
Message-ID: <20220226113538.6def80d0@windsurf> (raw)
In-Reply-To: <20220225113400.802049-5-kamel.bouhara@bootlin.com>
On Fri, 25 Feb 2022 12:34:00 +0100
Kamel Bouhara via buildroot <buildroot@buildroot.org> wrote:
> Add host variant of libodb-boost required by host-odb package.
This is a bit short, and I think just like PATCH 3/4, it needs a more
extensive explanation that the ODB compiler needs the libodb-boost
headers at compile time, and therefore installed in $(HOST_DIR).
> diff --git a/package/libodb-boost/libodb-boost.mk b/package/libodb-boost/libodb-boost.mk
> index bac5f1e78f..7f2ad1fe72 100644
> --- a/package/libodb-boost/libodb-boost.mk
> +++ b/package/libodb-boost/libodb-boost.mk
> @@ -11,7 +11,10 @@ LIBODB_BOOST_SITE = https://www.codesynthesis.com/download/odb/$(LIBODB_BOOST_VE
> LIBODB_BOOST_INSTALL_STAGING = YES
> LIBODB_BOOST_LICENSE = GPL-2.0
> LIBODB_BOOST_LICENSE_FILES = LICENSE
> -LIBODB_BOOST_DEPENDENCIES = boost libodb
> +LIBODB_BOOST_DEPENDENCIES = boost libodb \
> + host-boost \
> + host-libodb
This seems wrong. Why is libodb-boost depending on host-libodb-boost.
At least, this makes the dependencies added in your PATCH 2/4 a bit
irrelevant.
I guess what you need to do instead is:
HOST_LIBODB_BOOST_DEPENDENCIES = hoost-boost host-libodb
And rely on the logic in odb.mk to pull in host-libodb-boost when
BR2_PACKAGE_LIBODB_BOOST=y.
Could you fix your patch series, and send a new iteration?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-26 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 11:33 [Buildroot] [PATCH 0/4] Add odb host variant and fix gcc-11 build Kamel Bouhara via buildroot
2022-02-25 11:33 ` [Buildroot] [PATCH 1/4] package/odb: backport more upstream commits to fix build with gcc 11.x Kamel Bouhara via buildroot
2022-02-25 11:33 ` [Buildroot] [PATCH 2/4] package/odb: add dependency on host-libodb Kamel Bouhara via buildroot
2022-02-26 10:32 ` Thomas Petazzoni via buildroot
2022-02-25 11:33 ` [Buildroot] [PATCH 3/4] package/libodb: add host variant Kamel Bouhara via buildroot
2022-02-26 10:32 ` Thomas Petazzoni via buildroot
2022-02-25 11:34 ` [Buildroot] [PATCH 4/4] package/libodb-boost: " Kamel Bouhara via buildroot
2022-02-26 10:35 ` Thomas Petazzoni via buildroot [this message]
2022-03-10 8:51 ` Kamel Bouhara via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220226113538.6def80d0@windsurf \
--to=buildroot@buildroot.org \
--cc=kamel.bouhara@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox