Re: [Buildroot] [PATCH v2 1/1] package/rpi-userland: add support for aarch64 build

[Peter Seiderer <ps.report@gmx.net>]

Hello Christian,

On Mon, 7 Mar 2022 15:03:25 -0800, Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> Hi Peter,
>
> You're probably right about that:
>
> On Mon, Mar 7, 2022 at 2:54 PM Peter Seiderer <ps.report@gmx.net> wrote:
> > On Mon,  7 Mar 2022 14:42:26 -0800, Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> >
> > > Tested on Pi4 Model B (aarch64).
> > >
> > > Note: rpi-userland and upstream rpi os now support arm64.
> >
> > All issues/questions solved since discussion [1], [2] about
> > missing libraries/features?
> >
> > As far as I know rpi os graphic support is based on mesa3d v3d/vc4
> > instead of rpi-userland libraries?
>
> I use this package on arm64 for vcgencmd (videocore) and other commands,
>
> however I have not verified that graphics work correctly, and you're
> most likely correct,
>
> the arm64 stack probably is using mesa3d vc4. I boot the pi4 64 bit with:
>
> arm_64bit=1
> dtoverlay=vc4-fkms-v3d
>
> So this is using vc4, as you've mentioned here.
>
> I suppose to fix this patch, it needs something like:
>
> ifeq ($(BR2_aarch64),y)
> RPI_USERLAND_CONF_OPTS += -DARM64=ON
> else
> RPI_USERLAND_PROVIDES = libegl libgles libopenmax libopenvg
> endif
>
> Is this correct?

Did not (yet/lately) check if really all the above libs are disabled
with the ARM64 feature, but at least a starting point for the aarch64
use case....

But needs a corresponding aarch64 handling in package/rpi-userland/Config.in
too (select BR2_PACKAGE_HAS_LIBEGL, select BR2_PACKAGE_HAS_LIBGLES
select BR2_PACKAGE_HAS_LIBOPENVG, select BR2_PACKAGE_HAS_LIBOPENMAX, ...)
and maybe the help text needs to be adjusted...

>
> Thanks & best,
> Christian Stewart
>
> > Regards,
> > Peter
> >
> > [1] http://lists.busybox.net/pipermail/buildroot/2020-June/587538.html
> > [2] http://lists.busybox.net/pipermail/buildroot/2021-October/626080.html
>
> PS: I've noticed that my e-mail / name is wrong again:
>
> Christian Stewart via buildroot <buildroot@buildroot.org>
>
> is this on your end or mine?

Maybe both, I got your original email with

	From: Christian Stewart via buildroot <buildroot@buildroot.org>
	CC: Christian Stewart <christian@paral.in>, ...
	Reply-To: Christian Stewart <christian@paral.in>

My email client (Claws Mail) seems to ignore the Reply-To field leading to

	To: Christian Stewart via buildroot <buildroot@buildroot.org>
	CC: Christian Stewart <christian@paral.in>
	CC: ...

But the copy from the mailing list I receive is missing the

	CC: Christian Stewart <christian@paral.in>

but keeps the other CC recipients...

Regards,
Peter

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot