Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Simon Doppler <dopsi@dopsi.ch>
Cc: Danilo <mail@dbrgn.ch>, buildroot@buildroot.org
Subject: Re: [Buildroot] Patching buildroot package makefiles with BR2_EXTERNAL
Date: Wed, 9 Mar 2022 21:10:30 +0100	[thread overview]
Message-ID: <20220309201030.GA23050@scaer> (raw)
In-Reply-To: <3677050fbcbf7d7e31d8c6c12924f648d0e37d2a.camel@dopsi.ch>

Simon, Danillo, All,

On 2022-03-09 11:30 +0100, Simon Doppler spake thusly:
> > > I did expect that adding the dependency as you did would work but
> > > it
> > > failed: they show up when running `make arm-
> > > trusted-firmware-show-depends` but not in `make arm-trusted-
> > > firmware-show-build-order`. Does the same happen for you?
> > 
> > Yes, same issue for me. "make nginx-show-depends" includes "nginx-
> > rtmp-module",
> > but "make nginx-show-build-order" does not.
> > 
> > Manually building the module before building nginx does work, but it
> > would be
> > nice if there were a clean fix.
> 
> I submitted a bug report [1], with some extra info I found by digging
> around today.
> 
> I will continue to dig around in the coming weeks but it will still not
> be high on my priorities.

The value of FOO_DEPENDENCIES are used to generate Makefile-level
dependencies, and that is done at the time a package infra is called.

I.e. when your foo.mk has:
    FOO_DPEENDENCIES = bar
    $(eval $(generic-pakcage))

This is turned into Makefile code like:
    foo: bar

Which means that, modifying FOO_DEPENDENCIES later on will have no
impact in the actual dependency chain.

br2-external trees are meant to add new packages, and it is not possible
to modify existing packages.

In the current state, you have no way but to modify nginx.mk in the
Buildroot tree.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-03-09 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  8:57 [Buildroot] Patching buildroot package makefiles with BR2_EXTERNAL Danilo
2022-03-08 10:19 ` Simon Doppler
2022-03-08 22:58   ` Danilo
2022-03-09 10:30     ` Simon Doppler
2022-03-09 20:10       ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309201030.GA23050@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=dopsi@dopsi.ch \
    --cc=mail@dbrgn.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox