From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Peter Seiderer <ps.report@gmx.net>,
John Keeping <john@metanate.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/openssh: backport upstream fix for 32-bit
Date: Sat, 12 Mar 2022 17:24:01 +0100 [thread overview]
Message-ID: <20220312162401.GG283544@scaer> (raw)
In-Reply-To: <3ce1b58b-7721-a63a-4503-11e89fd55f22@mind.be>
Arnout, Peter, All,
On 2022-03-12 17:00 +0100, Arnout Vandecappelle spake thusly:
> On 11/03/2022 08:24, Peter Seiderer wrote:
> >But the sha1 alone does not tell to which git repo it belongs to, but the explicit
> >upstream link does (and has the nice effect to gain a one-click link to the
> >corresponding patch/merge-request etc.) and is a prominent remainder in case
> >of package version bump where the patch comes from...
> I don't know about you, but the normal way that I generate patches is to
> clone the repo and do 'git format-patch -1 <sha1>', and then add my SoB. And
> if it doesn't apply cleanly, I first do 'git cherry-pick -x -s'.
Exactly what I do too, with an additional tag just before my SoB:
[yann.morin.1998@free.fr: backport from upstream]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Obviously it's helpful to have a link there. However, requiring
> contributors to go and find the upstream web frontend and construct a URL is
> IMHO asking a lot, especially since chances are that no one is ever going to
> actually look at that link. There's already plenty of steps a contributor
> has to go through, I don't want to increase the threshold even more.
I fully subscribe to Arnout's position.
I only add an URL to the original patch if it was grabbed fro; a pending
PR/MR/BZ/.. or a third-party tree.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-03-12 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 14:03 [Buildroot] [PATCH] package/openssh: backport upstream fix for 32-bit John Keeping
2022-03-10 20:38 ` Peter Seiderer
2022-03-10 21:03 ` Arnout Vandecappelle
2022-03-11 7:24 ` Peter Seiderer
2022-03-12 16:00 ` Arnout Vandecappelle
2022-03-12 16:24 ` Yann E. MORIN [this message]
2022-03-18 8:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220312162401.GG283544@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=john@metanate.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox