From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Peter Seiderer <ps.report@gmx.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] package/wget: bump version to 1.21.3
Date: Tue, 15 Mar 2022 22:05:31 +0100 [thread overview]
Message-ID: <20220315220531.2bac9c2d@windsurf> (raw)
In-Reply-To: <20220311065042.8687-1-ps.report@gmx.net>
Hello Peter,
On Fri, 11 Mar 2022 07:50:42 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> - explicit set some default options (--without-metalink, --enable-opie,
> --enable-digest, --enable-ntlm, --disable-debug, --disable-valgrind-tests,
> --disable-assert)
>
> - add optional libpsl dependency
>
> - remove legacy --with-libidn option (see [1]), replace with
> new --enable-iri option in case libiconv and libidn2 are available
>
> - use explicit --with-libuuid option
>
> - add optional c-ares dependency
>
> For details see [2].
>
> [1] https://git.savannah.gnu.org/cgit/wget.git/commit/configure.ac?id=a24e67e239ef949cc77a4c4e5a0beb703026a296
> [2] https://lists.gnu.org/archive/html/info-gnu/2022-02/msg00017.html
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
You're mixing up a minor version bump with a significant rework of the
package, which is unrelated to the version bump. This really needs
separate commit. Also, see below.
> +WGET_CONF_OPTS = \
> + --without-metalink \
> + --enable-opie \
> + --enable-digest \
> + --enable-ntlm \
So opie, digest and ntlm enabled is the default?
> + --disable-debug \
> + --disable-valgrind-tests \
> + --disable-assert
> +
> +ifeq ($(BR2_PACKAGE_LIBPSL),y)
> +WGET_CONF_OPTS += --with-libpsl
> +WGET_DEPENDENCIES += libpsl
> +else
> +WGET_CONF_OPTS += --without-libpsl
> +endif
> +
> ifeq ($(BR2_PACKAGE_GNUTLS),y)
> WGET_CONF_OPTS += --with-ssl=gnutls
> WGET_DEPENDENCIES += gnutls
> @@ -22,19 +38,18 @@ else
> WGET_CONF_OPTS += --without-ssl
> endif
>
> -ifeq ($(BR2_PACKAGE_LIBICONV),y)
> -WGET_DEPENDENCIES += libiconv
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBIDN2),y)
> -WGET_CONF_OPTS += --with-libidn
> -WGET_DEPENDENCIES += libidn2
> +ifeq ($(BR2_PACKAGE_LIBICONV)$(BR2_PACKAGE_LIBIDN2),yy)
This is very likely wrong. Indeed BR2_PACKAGE_LIBICONV=y is only
possible when the toolchain does *not* have locale support. When the
toolchain has locale support, iconv support is provided by the
toolchain itself.
Could you revisit this, and also clarify the interaction between
--enable-iri/--disable-iri on one side and
--with-libidn/--without-libidn on the other side?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-03-15 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 6:50 [Buildroot] [PATCH v1] package/wget: bump version to 1.21.3 Peter Seiderer
2022-03-15 21:05 ` Thomas Petazzoni via buildroot [this message]
2022-03-16 20:39 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315220531.2bac9c2d@windsurf \
--to=buildroot@buildroot.org \
--cc=ps.report@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox