Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: "Sassen, Rutger" <rsassen@comecer.com>
Cc: Martin Bark <martin@barkynet.com>,
	Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v3 1/1] package/rpi-firmware: fix missing files in overlays
Date: Thu, 17 Mar 2022 19:03:06 +0100	[thread overview]
Message-ID: <20220317190306.1e427303@gmx.net> (raw)
In-Reply-To: <YQXPR01MB61216162093E0D5F17304D0BAE129@YQXPR01MB6121.CANPRD01.PROD.OUTLOOK.COM>

Hello Rutger,

On Thu, 17 Mar 2022 11:06:22 +0000, "Sassen, Rutger" <rsassen@comecer.com> wrote:

> When supporting multiple hardware targets, overlay_map.dtb might
> be needed to map overlay names to one of several implementations.
>
> Signed-off-by: Rutger Sassen <rsassen@comecer.com>

Thanks for new patch iteration...

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter


> ---
> Changes v2 -> v3:
>  - in Config.in use if statement instead of depends (suggested by Peter
>    Seiderer)
>  - mention the filename overlay_map.dtb in the help text (suggested by
>    Peter Seiderer)
>
> Changes v1 -> v2:
>   - instead of always copying overlay_map.dtb, make it configurable
>     (suggested by Peter Seiderer)
>   - do not copy README since it a special case, only needed when
>     installing overlays to a non-standard location (suggested by Peter
>     Seiderer)
>
> When supporting multiple hardware targets, overlay_map.dtb might
> be needed to map overlay names to one of several implementations.
>
> Signed-off-by: Rutger Sassen <rsassen@comecer.com>
> ---
>  package/rpi-firmware/Config.in       | 12 ++++++++++++
>  package/rpi-firmware/rpi-firmware.mk |  7 +++++++
>  2 files changed, 19 insertions(+)
>
> diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> index 8070dc3019..36054353f8 100644
> --- a/package/rpi-firmware/Config.in
> +++ b/package/rpi-firmware/Config.in
> @@ -93,6 +93,18 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
>  	  overlays, to support HATs (Hardware Attached on Top, add-on
>  	  modules).
>
> +if BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> +
> +config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP
> +	bool "Install DTB overlay map"
> +	default n
> +	help
> +	  Say 'y' here if you need to support multiple hardware targets
> +	  and you need overlay_map.dtb for target dependent mapping of
> +	  overlay names to one of several overlay implementations.
> +
> +endif # BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> +
>  config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG
>  	bool "vcdbg"
>  	depends on BR2_arm # prebuilt arm binary, rpi-userland
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index b46a7f5270..800b560070 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -57,6 +57,12 @@ define RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
>  endef
>  endif
>
> +ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP),y)
> +define RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP
> +	$(INSTALL) -D -m 0644 $(@D)/boot/overlays/overlay_map.dtb $(BINARIES_DIR)/rpi-firmware/overlays/
> +endef
> +endif
> +
>  # Install prebuilt libraries if RPI_USERLAND not enabled
>  ifneq ($(BR2_PACKAGE_RPI_USERLAND),y)
>  define RPI_FIRMWARE_INSTALL_TARGET_LIB
> @@ -83,6 +89,7 @@ define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
>  	$(RPI_FIRMWARE_INSTALL_CONFIG)
>  	$(RPI_FIRMWARE_INSTALL_DTB)
>  	$(RPI_FIRMWARE_INSTALL_DTB_OVERLAYS)
> +	$(RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP)
>  endef
>
>  $(eval $(generic-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-03-17 18:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 11:06 [Buildroot] [PATCH v3 1/1] package/rpi-firmware: fix missing files in overlays Sassen, Rutger
2022-03-17 18:03 ` Peter Seiderer [this message]
2022-03-17 19:02 ` Bartosz Bilas
2022-03-21 21:56 ` Arnout Vandecappelle
2022-03-22  8:16   ` [Buildroot] [External] " Sassen, Rutger
2022-03-23 19:35   ` [Buildroot] " Peter Seiderer
2022-03-23 19:49     ` Peter Seiderer
2022-03-23 20:06     ` Arnout Vandecappelle
2022-03-23 21:40 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220317190306.1e427303@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    --cc=mahyar.koshkouei@gmail.com \
    --cc=martin@barkynet.com \
    --cc=rsassen@comecer.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox