Re: [Buildroot] [PATCH v2 1/5] package/wget: explicit set some default options

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Peter, All,

On 2022-03-18 21:20 +0100, Peter Seiderer spake thusly:
> - explicit set some default options (--without-metalink, --enable-opie,
>   --enable-digest, --enable-ntlm, --disable-debug, --disable-valgrind-tests,
>   --disable-assert)

Repeating the title and the code in the commit message is not very
helpful.

What would be more intertesting, is to explain why you did need to set
those options, and just those, among all the others that are available,
like attr, iri... (I think that is basically what Thomas asked for in
his review of your v1).

I see that your series will also introduces some optional support
(libpsl, c-ares), but if just this first patch is applied, then that
also leaves those options unset, so this first patch should really add
defaults to all options.

Regards,
Yann E. MORIN.

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - split out from original patch
> ---
>  package/wget/wget.mk | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/package/wget/wget.mk b/package/wget/wget.mk
> index f30fa39917..d100a59eae 100644
> --- a/package/wget/wget.mk
> +++ b/package/wget/wget.mk
> @@ -12,6 +12,15 @@ WGET_LICENSE = GPL-3.0+
>  WGET_LICENSE_FILES = COPYING
>  WGET_CPE_ID_VENDOR = gnu
>  
> +WGET_CONF_OPTS = \
> +	--without-metalink \
> +	--enable-opie \
> +	--enable-digest \
> +	--enable-ntlm \
> +	--disable-debug \
> +	--disable-valgrind-tests \
> +	--disable-assert
> +
>  ifeq ($(BR2_PACKAGE_GNUTLS),y)
>  WGET_CONF_OPTS += --with-ssl=gnutls
>  WGET_DEPENDENCIES += gnutls
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot