Re: [Buildroot] [PATCH 1/1] package/aufs: don't set invalid AUFS_SITE if version is unset

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2022-04-08 17:56 -0600, James Hilliard spake thusly:
> On Tue, Apr 5, 2022 at 3:12 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2022-04-05 14:09 -0600, James Hilliard spake thusly:
> > > On Tue, Apr 5, 2022 at 11:19 AM Arnout Vandecappelle <arnout@mind.be> wrote:
> > > > On 05/04/2022 04:50, James Hilliard wrote:
> > > > > Fixes:
> > > > > package/aufs/aufs.mk:24: *** AUFS_SITE (https://github.com/sfjro/aufs4-standalone/archive/) cannot have a trailing slash.  Stop.
> > > > > make: *** [Makefile:84: _all] Error 2
> > > >   How do you get this? I've tried a number of configurations, but I always get
> > > > package/aufs/aufs.mk:21: *** No aufs version specified.  Stop.
> > > > make: *** [Makefile:84: _all] Error 2
> > > >   I could only reproduce with `make source`, but that's a bit a special case.
> > > Something like this seems to hit it:
> > > BR2_LINUX_KERNEL_EXT_AUFS=y
> > > # BR2_LINUX_KERNEL_EXT_AUFS_SERIES_3 is not set
> > > BR2_LINUX_KERNEL_EXT_AUFS_SERIES_4=y
> > > # BR2_LINUX_KERNEL_EXT_AUFS_SERIES_5 is not set
> > > BR2_LINUX_KERNEL_EXT_AUFS_SERIES=4
> > > BR2_LINUX_KERNEL_EXT_AUFS_VERSION=""
> > > BR2_PACKAGE_AUFS=y
> > > BR2_PACKAGE_AUFS_SERIES=4
> > > BR2_PACKAGE_AUFS_VERSION=""
> > > # BR2_PACKAGE_AUFS_UTIL is not set
> > This still produces the expected error that Arnout reported:
[--SNIP--]
> You need to do make savedefconfig here for it to reproduce:
[--SNIP--]

Indeed, I could reproduce.

However, I think the fix is still incorrect.

Indeed, if we were to do what you suggest, them it would be possible to
call savedefconfig on a broken configuration; this does not make sense.

Instead, I believe that savedefconfig and update-defconfig (an alias for
the former) should not be declared as nobuild_targets:

    diff --git a/Makefile b/Makefile
    index 05b790d770..69994a58da 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -141,7 +141,7 @@ nobuild_targets := source %-source \
     	clean distclean help show-targets graph-depends \
     	%-graph-depends %-show-depends %-show-version \
     	graph-build graph-size list-defconfigs \
    -	savedefconfig update-defconfig printvars show-vars
    +	printvars show-vars
     ifeq ($(MAKECMDGOALS),)
     BR_BUILDING = y
     else ifneq ($(filter-out $(nobuild_targets),$(MAKECMDGOALS)),)

There are a bout ~35 places where we use $(BR_BUILDING). I've look at
all the instances in boot/ and linux/,i in toolchain/ and package/aufs/
of course, and a few others, and they all seem to be fine if we remove
savedefconfig and update-defconfig from nobuild_targets.

Care to have a further look, please, and send a patch?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot