Re: [Buildroot] [PATCH 1/1] boot/shim: disable on mips64el

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 19 Apr 2022 14:14:09 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure on mips64el raised since commit
> 11b347c03ab0b38389ec11b48f63236a3b4d6547:
> 
> In file included from shim.h:47,
>                  from shim.c:14:
> /nvmedata/autobuild/instance-17/output-1/build/shim-15.4/include/system/stdarg.h:72:2: error: #error what arch is this
>    72 | #error what arch is this
>       |  ^~~~~

As usual, I don't like this kind of fixes that consist in simply "let's
disable in the specific case that causes problem". If you look at that
include/system/stdarg.h, you see:

#if defined(__aarch64__) || defined(__arm__) || defined(__i386__) || \
        defined(__i486__) || defined(__i686__)

...

#elif defined(__x86_64__)

...

#else
#error what arch is this
#endif

So basically, any architecture other than the ones listed above is
going to raise this build issue, not just mips64el.

Yes, BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS already disables on most CPU
architectures, but shim also has its own list of CPU architectures it
supports. So we probably want a BR2_TARGET_SHIM_ARCH_SUPPORTS, which
depends on BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS and then adds an explicit
list of architectures that shim supports.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot