Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: Norbert Lange <nolange79@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/systemd: add the missing sgx group
Date: Thu, 21 Apr 2022 21:16:53 +0200	[thread overview]
Message-ID: <20220421191653.GO2730@scaer> (raw)
In-Reply-To: <20220420135549.3536397-1-tianyuanhao3@163.com>

Yuanhao, All,

On 2022-04-20 06:55 -0700, TIAN Yuanhao spake thusly:
> systemd-udevd needs this group:
>   /usr/lib/udev/rules.d/50-udev-default.rules:43 Unknown group 'sgx', ignoring
> 
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> ---
>  package/systemd/systemd.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index b07fac27d4..44185a35a0 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -603,6 +603,7 @@ endef
>  
>  define SYSTEMD_USERS
>  	# udev user groups
> +	- - sgx -1 * - - - SGX device nodes

This should have been in the udev virtual package, as all the
udev-related users and groups have been moved there to be common between
systemd-udevd and the stand-alone eudev, in commit d648d81dd581
(packages/{eudev, systemd}: move common users to package/udev).

Applied to master with this fixed, thanks.

Would you be kind enough to send a follow-up patch that removes the now
misleading "# udev user groups" comment, and adds a comment, in systemd
and eudev, that directs changes to the udev virtual package instead,
please?

Regards,
Yann E. MORIN.

>  	# systemd user groups
>  	- - systemd-journal -1 * - - - Journal
>  	$(SYSTEMD_REMOTE_USER)
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-21 19:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 13:55 [Buildroot] [PATCH] package/systemd: add the missing sgx group TIAN Yuanhao
2022-04-21 19:16 ` Yann E. MORIN [this message]
2022-04-21 23:55   ` TIAN Yuanhao
2022-04-24 14:50     ` Yann E. MORIN
2022-05-24  8:19 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220421191653.GO2730@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=nolange79@gmail.com \
    --cc=tianyuanhao3@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox