From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2714AC433F5 for ; Sun, 24 Apr 2022 08:55:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D8F1781A16; Sun, 24 Apr 2022 08:55:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IUe3zVYkPyVX; Sun, 24 Apr 2022 08:55:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id B179D819BE; Sun, 24 Apr 2022 08:55:06 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 942F91BF3C1 for ; Sun, 24 Apr 2022 08:55:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8FDD240432 for ; Sun, 24 Apr 2022 08:55:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=free.fr Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EWLH3hB6QWLz for ; Sun, 24 Apr 2022 08:55:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6]) by smtp2.osuosl.org (Postfix) with ESMTPS id E903240104 for ; Sun, 24 Apr 2022 08:55:03 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:657d:21bd:cb37:8719]) (Authenticated sender: yann.morin.1998@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 9E91F7802C2; Sun, 24 Apr 2022 10:54:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1650790501; bh=vHvn/5ov+Y2idHrfWGXnMqhjltbBeRlzOl5rXxqN6WU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r3uRm9xgcgv+mstHe9QRpEgnb63PUeUtmmv9U4F0FZUig0wafICRrtDefvkDiiXj4 A4Ek3jmR1Tv3mJxmQQL31jgvCCDJOWh1sHL+cmi8MRIp1KtNtDlslMSl618XiGpJ6w c0OJcEImUR7+mSbQLlajoi77puNwj7MBYjvphzRN2XcueNukjeBGQsBPHHcaUmpDub tVPK1JLcyJ7xZsKHzSCXb3UpxUZpCRkFfo7QpNXNG6ESa1eMmbYeOSPudMU4SrC8c1 GtgJ0I4ASRHK1DYkZNBrAvea/jDHDMj6AIwfUwTRdiBYbYcIZ9p/SQHQwR/rlK8zTL iX04qiJtYpZuQ== Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sun, 24 Apr 2022 10:54:54 +0200 Date: Sun, 24 Apr 2022 10:54:54 +0200 From: "Yann E. MORIN" To: Thomas Petazzoni Message-ID: <20220424085454.GS2730@scaer> References: <20220419213450.887728-1-thomas.petazzoni@bootlin.com> <20220419213450.887728-4-thomas.petazzoni@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419213450.887728-4-thomas.petazzoni@bootlin.com> User-Agent: Mutt/1.5.22 (2013-10-16) Subject: Re: [Buildroot] [PATCH 4/5] arch: drop support for SH2A X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Giulio Benetti , James Hilliard , Romain Naour , Thomas De Schampheleire , Buildroot List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Thomas, All, On 2022-04-19 23:34 +0200, Thomas Petazzoni via buildroot spake thusly: > Until commit "arch/Config.in.sh: fixup MMU selection" in this series, > SH2A could either be used with BR2_USE_MMU disabled or BR2_USE_MMU > enabled. > > The later made absolutely no sense, since SH2A does not have a MMU: > MMU support was introduced starting from SH3 according to > https://en.wikipedia.org/wiki/SuperH#SH-3 > > Also, since commit 22d5501e03b019218b718b5de7ca74824a8eaf42 ("arch: > tidy up binary formats config"), which was merged in Buildroot > 2015.05, the architecture tuple used when BR2_sh2a=y and BR2_USE_MMU > disabled is sh2a-buildroot-uclinux-uclibc, and this was already > unsupported back in the days of Buildroot 2015.08 and binutils 2.24, > causing the build to fail with: > > *** BFD does not support target sh2a-buildroot-uclinux-uclibc. > > just like it fails to build today with recent version of binutils. > > So, this has been broken since 2015.08, and nobody complained. SH2A is > seldomly used, so it's time to kill. seldomly is archaic [0]; seldom is an adverb [1]. ;-) [0] https://www.merriam-webster.com/dictionary/seldomly [1] https://www.merriam-webster.com/dictionary/seldom Applied to master, thanks. Regards, Yann E. MORIN. > It is worth mentioning that there has been an attempt at resurrecting > SH2 support around 2015 (see https://lwn.net/Articles/647636/) as part > of the J2 core. This effort led to the addition of FDPIC support for > SH2A in the musl C library (and therefore proper ELF binaries, with > shared libraries), but that was never supported in Buildroot. Now that > the J2 project is essentially dead, there is no reason to bother with > this. > > Fixes: > > http://autobuild.buildroot.net/results/63d01d33ae30f86b63b9f42a9fea116f2f3e9005/ > > Signed-off-by: Thomas Petazzoni > --- > Config.in.legacy | 7 +++++++ > arch/Config.in.sh | 5 +---- > package/uclibc/Config.in | 1 - > toolchain/toolchain-buildroot/Config.in | 2 +- > utils/genrandconfig | 9 +++------ > 5 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/Config.in.legacy b/Config.in.legacy > index 27f19f14e7..1578ffd016 100644 > --- a/Config.in.legacy > +++ b/Config.in.legacy > @@ -146,6 +146,13 @@ endif > > comment "Legacy options removed in 2022.05" > > +config BR2_sh2a > + bool "sh2a architecture support removed" > + select BR2_LEGACY > + help > + The SuperH 2A (SH2A) architecture was not maintained, and > + broken, so its support was dropped. > + > config BR2_PACKAGE_BOOST_LAYOUT_VERSIONED > bool "boost versioned layout removed" > select BR2_LEGACY > diff --git a/arch/Config.in.sh b/arch/Config.in.sh > index a012cbf491..f00954bb5e 100644 > --- a/arch/Config.in.sh > +++ b/arch/Config.in.sh > @@ -5,8 +5,6 @@ choice > help > Specific CPU variant to use > > -config BR2_sh2a > - bool "sh2a (SH2A big endian)" > config BR2_sh4 > bool "sh4 (SH4 little endian)" > select BR2_ARCH_HAS_MMU_MANDATORY > @@ -22,7 +20,6 @@ config BR2_sh4aeb > endchoice > > config BR2_ARCH > - default "sh2a" if BR2_sh2a > default "sh4" if BR2_sh4 > default "sh4eb" if BR2_sh4eb > default "sh4a" if BR2_sh4a > @@ -33,7 +30,7 @@ config BR2_NORMALIZED_ARCH > > config BR2_ENDIAN > default "LITTLE" if BR2_sh4 || BR2_sh4a > - default "BIG" if BR2_sh2a || BR2_sh4eb || BR2_sh4aeb > + default "BIG" if BR2_sh4eb || BR2_sh4aeb > > config BR2_READELF_ARCH_NAME > default "Renesas / SuperH SH" > diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in > index 2091166b62..310414bebc 100644 > --- a/package/uclibc/Config.in > +++ b/package/uclibc/Config.in > @@ -124,7 +124,6 @@ config BR2_UCLIBC_MIPS_NAN > > config BR2_UCLIBC_SH_TYPE > string > - default "SH2A" if BR2_sh2a > default "SH4" if BR2_sh4 || BR2_sh4eb > depends on BR2_UCLIBC_TARGET_ARCH = "sh" > > diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in > index 4004c0edf8..be89f68ab5 100644 > --- a/toolchain/toolchain-buildroot/Config.in > +++ b/toolchain/toolchain-buildroot/Config.in > @@ -31,7 +31,7 @@ config BR2_TOOLCHAIN_BUILDROOT_UCLIBC > BR2_arm || BR2_armeb || \ > BR2_i386 || BR2_m68k || BR2_microblaze || \ > BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ > - BR2_or1k || BR2_powerpc || BR2_RISCV_64 || BR2_sh2a || \ > + BR2_or1k || BR2_powerpc || BR2_RISCV_64 || \ > BR2_sh4 || BR2_sh4eb || BR2_sparc || BR2_xtensa || \ > BR2_x86_64 > select BR2_TOOLCHAIN_USES_UCLIBC > diff --git a/utils/genrandconfig b/utils/genrandconfig > index 59fe34e58d..adefb8f502 100755 > --- a/utils/genrandconfig > +++ b/utils/genrandconfig > @@ -237,12 +237,9 @@ def fixup_config(sysinfo, configfile): > if 'BR2_PACKAGE_PYTHON3=y\n' in configlines and \ > BR2_TOOLCHAIN_EXTERNAL_URL + 'mips64el-ctng_n64-linux-gnu.tar.xz"\n' in configlines: > return False > - # libffi not available on sh2a and ARMv7-M, but propagating libffi > - # arch dependencies in Buildroot is really too much work, so we > - # handle this here. > - if 'BR2_sh2a=y\n' in configlines and \ > - 'BR2_PACKAGE_LIBFFI=y\n' in configlines: > - return False > + # libffi not available on ARMv7-M, but propagating libffi arch > + # dependencies in Buildroot is really too much work, so we handle > + # this here. > if 'BR2_ARM_CPU_ARMV7M=y\n' in configlines and \ > 'BR2_PACKAGE_LIBFFI=y\n' in configlines: > return False > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot