Re: [Buildroot] [PATCH v2 3/3] package/binutils: drop version 2.32

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2 3/3] package/binutils: drop version 2.32
Date: Wed, 27 Apr 2022 23:45:29 +0200	[thread overview]
Message-ID: <20220427214529.GC3624965@scaer> (raw)
In-Reply-To: <20220426215315.381964-3-thomas.petazzoni@bootlin.com>

p
Thomas, All,

On 2022-04-26 23:53 +0200, Thomas Petazzoni via buildroot spake thusly:
> Now that recent versions of binutils work with FLAT binaries, we can
> drop the old 2.32 version, which was kept only to keep support FLAT
> binaries.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

As seen on IRC: binutils-2.32 is the latest version that can still build
afboot-stm32. binutils-2.36.1 onward break the build.

As you noticed, this is because of:
    https://github.com/mcoquelin-stm32/afboot-stm32/commit/0f3e61c9dd48fd8b4248ce4672c044c2562e4de1

That change is wrong: -nostartfiles is a gcc option, not an ld option.

Older ld version seemed to somehow ignore it, while at least since
2.36.1 it is now an error:

    ...ld.real: Error: unable to disambiguate: -nostartfiles (did you mean --nostartfiles ?)

This is because, starting with binutils 2.36, ld got an improved flag
parsing that now generates that error (but that's incorrect too, as
--nostartfiles does not exist either). -nostartfiles is a gcc option,
but afboot-stm32 directly calls the linker...

A similar issue was raised fot at91bootstrap, and fixed by removing
-nostarfiles:

    https://github.com/linux4sam/at91bootstrap/issues/127
    https://github.com/linux4sam/at91bootstrap/pull/129

So, as you said on IRC that you'd send a followup eries with a fix to
afboot-stm32, I've marked this series as changes requested in the
meantime.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot