From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Kristof Havasi <havasiefr@gmail.com>,
Buildroot List <buildroot@buildroot.org>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH] Revert "toolchain/toolchain-external: error if BR2_TOOLCHAIN_EXTERNAL_PATH is not set"
Date: Thu, 28 Apr 2022 23:55:36 +0200 [thread overview]
Message-ID: <20220428235536.73948423@windsurf> (raw)
In-Reply-To: <20220428215003.GG3624965@scaer>
On Thu, 28 Apr 2022 23:50:03 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> On 2022-04-28 23:20 +0200, Thomas Petazzoni via buildroot spake thusly:
> > This reverts commit 8945ba49480a7885d104445ca855ef7681a374ff.
>
> This is a commit on the 2022.02.x branch; it is a backport of
> 8e91385a2cb81c5f8114354f4494230e2aebb93a on master.
>
> Did you meant this patch to be applied only to 2022.02.x?
No.
> I would believe it should be applied to master and backported to 2022.02
> instead, no?
Yes, absolutely. I referred to 8e91385a2cb81c5f8114354f4494230e2aebb93a
because that's what the bug reporter pointed to as the offending
commit, as the bug report is on the 2022.02.x branch.
Though I agree the commit log should probably refer to the commit in
master. I can send a v2 if needed.
Thanks for the review!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-04-28 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 21:20 [Buildroot] [PATCH] Revert "toolchain/toolchain-external: error if BR2_TOOLCHAIN_EXTERNAL_PATH is not set" Thomas Petazzoni via buildroot
2022-04-28 21:50 ` Yann E. MORIN
2022-04-28 21:55 ` Thomas Petazzoni via buildroot [this message]
2022-04-28 22:04 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428235536.73948423@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=havasiefr@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox