Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Alexandre Esse <alexandre.esse.dev@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/v4l2loopback: add V4L2LOOPBACK_LINUX_CONFIG_FIXUPS
Date: Sat, 14 May 2022 15:36:41 +0200	[thread overview]
Message-ID: <20220514133641.GZ1597494@scaer> (raw)
In-Reply-To: <20220514092152.1625466-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-05-14 11:21 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure:
> 
> ERROR: modpost: "video_ioctl2" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "__video_register_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "v4l2_ctrl_new_custom" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "v4l2_ctrl_handler_init_class" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "video_device_alloc" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "v4l2_device_register" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "video_device_release" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "v4l2_ctrl_handler_free" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "v4l2_device_unregister" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> ERROR: modpost: "video_unregister_device" [/nvmedata/autobuild/instance-10/output-1/build/v4l2loopback-0.12.5/./v4l2loopback.ko] undefined!
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/640f8f61c7f433ffe5e9a6759eecc9a03f735569
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/v4l2loopback/v4l2loopback.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/v4l2loopback/v4l2loopback.mk b/package/v4l2loopback/v4l2loopback.mk
> index 7701bc3a30..712088b6b0 100644
> --- a/package/v4l2loopback/v4l2loopback.mk
> +++ b/package/v4l2loopback/v4l2loopback.mk
> @@ -15,5 +15,10 @@ define V4L2LOOPBACK_INSTALL_TARGET_CMDS
>  endef
>  endif
>  
> +define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT)

This one depends on CONFIG_HAS_IOMEM, which is always true, except on
s390x (needs PCI) or uml (but we don't support UML).

> +	$(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV)

That one also depends on CONFIG_I2C (which has no dependency).

So, maybe:

    define V4L2LOOPBACK_LINUX_CONFIG_FIXUPS
        $(if $(BR2_s390x),$(call KCONFIG_ENABLE_OPT,CONFIG_PCI))
        $(call KCONFIG_ENABLE_OPT,CONFIG_MEDIA_SUPPORT)
        $(call KCONFIG_ENABLE_OPT,CONFIG_I2C)
        $(call KCONFIG_ENABLE_OPT,CONFIG_VIDEO_DEV)
    endef

Cordialement,
Yann E. MORIN.

> +endef
> +
>  $(eval $(kernel-module))
>  $(eval $(generic-package))
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-05-14 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14  9:21 [Buildroot] [PATCH 1/1] package/v4l2loopback: add V4L2LOOPBACK_LINUX_CONFIG_FIXUPS Fabrice Fontaine
2022-05-14 13:36 ` Yann E. MORIN [this message]
2022-05-14 13:47   ` Fabrice Fontaine
2022-05-14 18:58     ` Yann E. MORIN
2022-07-26 21:37 ` Thomas Petazzoni via buildroot
2022-08-29  9:33   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220514133641.GZ1597494@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=alexandre.esse.dev@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox