Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] toolchain-buildroot: only allow BR2_STATIC_LIBS on supported archs
Date: Sun, 15 May 2022 23:09:19 +0200	[thread overview]
Message-ID: <20220515230919.491af84e@windsurf> (raw)
In-Reply-To: <20220506054651.2853406-1-james.hilliard1@gmail.com>

Hello James,

On Thu,  5 May 2022 23:46:51 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> +config BR2_TOOLCHAIN_BUILDROOT_UCLIBC_ARCH_SUPPORTS
> +	bool
> +	default y if BR2_aarch64
> +	default y if BR2_aarch64_be
> +	default y if BR2_arcle
> +	default y if BR2_arceb
> +	default y if BR2_arm
> +	default y if BR2_armeb
> +	default y if BR2_i386
> +	default y if BR2_m68k
> +	default y if BR2_microblaze
> +	default y if BR2_mips
> +	default y if BR2_mipsel
> +	default y if BR2_mips64
> +	default y if BR2_mips64el
> +	default y if BR2_or1k
> +	default y if BR2_powerpc
> +	default y if BR2_RISCV_64
> +	default y if BR2_sh4
> +	default y if BR2_sh4eb
> +	default y if BR2_sparc
> +	default y if BR2_xtensa
> +	default y if BR2_x86_64

This should probably go in package/uclibc/Config.in, and be named
BR2_PACKAGE_UCLIBC_ARCH_SUPPORTS

> +config BR2_TOOLCHAIN_BUILDROOT_GLIBC_ARCH_SUPPORTS
> +	bool

Ditto package/glibc/Config.in

> +config BR2_TOOLCHAIN_BUILDROOT_MUSL_ARCH_SUPPORTS
> +	bool

Ditto package/musl/Config.in

I believe it's a good idea to have the description of these
architecture dependencies into the C library packages themselves.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-05-15 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06  5:46 [Buildroot] [PATCH 1/1] toolchain-buildroot: only allow BR2_STATIC_LIBS on supported archs James Hilliard
2022-05-10 19:32 ` Arnout Vandecappelle
2022-05-10 19:55   ` James Hilliard
2022-05-11 17:13     ` Arnout Vandecappelle
2022-05-11 18:23       ` James Hilliard
2022-05-15 20:29         ` Romain Naour
2022-05-15 21:09 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220515230919.491af84e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=james.hilliard1@gmail.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox